Always write doc_values param to mapping for wildcard field #16988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfroh
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
reta
approved these changes
Jan 10, 2025
Contributor
|
❌ Gradle check result for 76cf569: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Member
Contributor
Author
I made a mistake making this parameter default to false. In 3.0, I would like to switch the default to true. An index upgraded from 2.x with the default (false) value should specifically emit the value to avoid implicitly picking up the new default (true). Signed-off-by: Michael Froh <[email protected]>
msfroh
force-pushed
the
explicit_docvalue_for_wildcard_field
branch
from
76cf569 to
0d2ee6a
Compare
Contributor
|
❌ Gradle check result for 0d2ee6a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16988 +/- ##
============================================
+ Coverage 72.21% 72.31% +0.10%
- Complexity 65289 65331 +42
============================================
Files 5301 5301
Lines 303725 303750 +25
Branches 44008 44011 +3
============================================
+ Hits 219340 219666 +326
+ Misses 66394 66071 -323
- Partials 17991 18013 +22 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Jan 29, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit cd149a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made a mistake making this parameter default to
false.In 3.0, I would like to switch the default to
true. An index upgraded from 2.x with the default (false) value should specifically emit the value to avoid implicitly picking up the new default (true).Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.