Fixed inefficient Stream API call chains ending with count()

[dk2k]

Fixed inefficient Stream API call chains ending with count()

[github-actions]

❌ Gradle check result for 72ebe23: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[github-actions]

❌ Gradle check result for f18aade: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[sandeshkr419]

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.17.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.17.0-SNAPSHOT-linux-x64.tar.gz

@dk2k I think you will have to rebase your changes against main branch for gradle checks to succeed since 2.17 is released after this PR was opened up.

[github-actions]

✅ Gradle check result for 759c383: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.99%. Comparing base (ec7b652) to head (6e65bca).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../java/org/opensearch/percolator/QueryAnalyzer.java	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15386      +/-   ##
============================================
- Coverage     72.00%   71.99%   -0.01%     
+ Complexity    64817    64806      -11     
============================================
  Files          5307     5307              
  Lines        302660   302664       +4     
  Branches      43724    43726       +2     
============================================
- Hits         217931   217914      -17     
+ Misses        66906    66875      -31     
- Partials      17823    17875      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbwiddis]

Thanks for these changes, @dk2k ! Appreciate your patience as we've reviewed them.

One last thing we'd like is an entry in CHANGELOG.md summarizing this PR. There's an open issue on percolator performance (#16285) so adding an entry showing an attempt to improve at least a portion of it would be helpful.

Ready to approve pending this entry.

[github-actions]

❕ Gradle check result for 12d35f1: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[dbwiddis]

Re-approving, will merge once CI completes

[github-actions]

✅ Gradle check result for 6e65bca: SUCCESS

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15386-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1a7018abf1884a287d05681358efa600471c810b
# Push it to GitHub
git push --set-upstream origin backport/backport-15386-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15386-to-2.x.