Fix the failing tests due to connection profile missing STREAM type

Signed-off-by: Rishabh Maurya <[email protected]>

Author: rishabhmaurya

server/src/main/java/org/opensearch/transport/ConnectionProfile.java

@@ -112,8 +112,8 @@ public static ConnectionProfile buildDefaultConnectionProfile(Settings settings)
         // if we are not a data-node we don't need any dedicated channels for recovery
         builder.addConnections(DiscoveryNode.isDataNode(settings) ? connectionsPerNodeRecovery : 0, TransportRequestOptions.Type.RECOVERY);
         builder.addConnections(connectionsPerNodeReg, TransportRequestOptions.Type.REG);
-        // TODO use different setting for connectionsPerNodeReg for stream request
-        builder.addConnections(connectionsPerNodeReg, TransportRequestOptions.Type.STREAM);
+        // we build a single channel profile with only supported type as STREAM for stream transport defined in StreamTransportService
+        builder.addConnections(0, TransportRequestOptions.Type.STREAM);
         return builder.build();
     }
 

server/src/main/java/org/opensearch/transport/StreamTransportService.java

@@ -113,7 +113,7 @@ public Transport.Connection getConnection(DiscoveryNode node) {
         try {
             return connectionManager.getConnection(node);
         } catch (Exception e) {
-            logger.error("Failed to get streaming connection to node [{}]", node, e);
+            logger.error("Failed to get streaming connection to node [{}]: {}", node, e.getMessage());
             throw new ConnectTransportException(node, "Failed to get streaming connection", e);
         }
     }

test/framework/src/main/java/org/opensearch/transport/AbstractSimpleTransportTestCase.java

@@ -2242,6 +2242,7 @@ public void testHandshakeUpdatesVersion() throws IOException {
                 TransportRequestOptions.Type.REG,
                 TransportRequestOptions.Type.STATE
             );
+            builder.addConnections(0, TransportRequestOptions.Type.STREAM);
             try (Transport.Connection connection = serviceA.openConnection(node, builder.build())) {
                 assertEquals(version, connection.getVersion());
             }