Move new param to the end

Signed-off-by: Asim Mahmood <[email protected]>

Author: asimmahmood1

server/src/main/java/org/opensearch/search/aggregations/metrics/CardinalityAggregationBuilder.java

@@ -173,11 +173,11 @@ protected CardinalityAggregatorFactory innerBuild(
             name,
             config,
             precisionThreshold,
-            executionHint,
             queryShardContext,
             parent,
             subFactoriesBuilder,
-            metadata
+            metadata,
+            executionHint
         );
     }
 

server/src/main/java/org/opensearch/search/aggregations/metrics/CardinalityAggregator.java

@@ -112,10 +112,10 @@ public CardinalityAggregator(
         String name,
         ValuesSourceConfig valuesSourceConfig,
         int precision,
-        CardinalityAggregatorFactory.ExecutionMode executionMode,
         SearchContext context,
         Aggregator parent,
-        Map<String, Object> metadata
+        Map<String, Object> metadata,
+        CardinalityAggregatorFactory.ExecutionMode executionMode
     ) throws IOException {
         super(name, context, parent, metadata);
         // TODO: Stop using nulls here

server/src/main/java/org/opensearch/search/aggregations/metrics/CardinalityAggregatorFactory.java

@@ -87,11 +87,11 @@ public String toString() {
         String name,
         ValuesSourceConfig config,
         Long precisionThreshold,
-        String executionHint,
         QueryShardContext queryShardContext,
         AggregatorFactory parent,
         AggregatorFactories.Builder subFactoriesBuilder,
-        Map<String, Object> metadata
+        Map<String, Object> metadata,
+        String executionHint
     ) throws IOException {
         super(name, config, queryShardContext, parent, subFactoriesBuilder, metadata);
         this.precisionThreshold = precisionThreshold;
@@ -104,7 +104,7 @@ public static void registerAggregators(ValuesSourceRegistry.Builder builder) {
 
     @Override
     protected Aggregator createUnmapped(SearchContext searchContext, Aggregator parent, Map<String, Object> metadata) throws IOException {
-        return new CardinalityAggregator(name, config, precision(), executionMode, searchContext, parent, metadata);
+        return new CardinalityAggregator(name, config, precision(), searchContext, parent, metadata, executionMode);
     }
 
     @Override
@@ -116,7 +116,7 @@ protected Aggregator doCreateInternal(
     ) throws IOException {
         return queryShardContext.getValuesSourceRegistry()
             .getAggregator(CardinalityAggregationBuilder.REGISTRY_KEY, config)
-            .build(name, config, precision(), executionMode, searchContext, parent, metadata);
+            .build(name, config, precision(), searchContext, parent, metadata, executionMode);
     }
 
     @Override

server/src/main/java/org/opensearch/search/aggregations/metrics/CardinalityAggregatorSupplier.java

@@ -49,9 +49,9 @@ Aggregator build(
         String name,
         ValuesSourceConfig valuesSourceConfig,
         int precision,
-        CardinalityAggregatorFactory.ExecutionMode executionMode,
         SearchContext context,
         Aggregator parent,
-        Map<String, Object> metadata
+        Map<String, Object> metadata,
+        CardinalityAggregatorFactory.ExecutionMode executionMode
     ) throws IOException;
 }