Skip to content

Commit 4e21c9d

Browse files
committed
Move getMetadataFields to IndexService
Signed-off-by: Craig Perkins <[email protected]>
1 parent bb9819c commit 4e21c9d

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

server/src/main/java/org/opensearch/index/IndexService.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ public class IndexService extends AbstractIndexComponent implements IndicesClust
156156
private final CheckedFunction<DirectoryReader, DirectoryReader, IOException> readerWrapper;
157157
private final IndexCache indexCache;
158158
private final MapperService mapperService;
159+
private final MapperRegistry mapperRegistry;
159160
private final NamedXContentRegistry xContentRegistry;
160161
private final NamedWriteableRegistry namedWriteableRegistry;
161162
private final SimilarityService similarityService;
@@ -239,6 +240,7 @@ public IndexService(
239240
this.circuitBreakerService = circuitBreakerService;
240241
this.expressionResolver = expressionResolver;
241242
this.valuesSourceRegistry = valuesSourceRegistry;
243+
this.mapperRegistry = mapperRegistry;
242244
if (needsMapperService(indexSettings, indexCreationContext)) {
243245
assert indexAnalyzers != null;
244246
this.mapperService = new MapperService(
@@ -1233,6 +1235,13 @@ private TimeValue getRefreshInterval() {
12331235
return clusterDefaultRefreshIntervalSupplier.get();
12341236
}
12351237

1238+
/**
1239+
* Returns a set containing the registered metadata fields
1240+
*/
1241+
public Set<String> getMetadataFields() {
1242+
return Collections.unmodifiableSet(mapperRegistry.getMetadataMapperParsers().keySet());
1243+
}
1244+
12361245
/**
12371246
* Base asynchronous task
12381247
*

server/src/main/java/org/opensearch/index/mapper/MapperService.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -714,13 +714,6 @@ public boolean isMetadataField(String field) {
714714
return mapperRegistry.isMetadataField(field);
715715
}
716716

717-
/**
718-
* Returns a set containing the registered metadata fields
719-
*/
720-
public Set<String> getMetadataFields() {
721-
return Collections.unmodifiableSet(mapperRegistry.getMetadataMapperParsers().keySet());
722-
}
723-
724717
/**
725718
* An analyzer wrapper that can lookup fields within the index mappings
726719
*/

server/src/test/java/org/opensearch/index/mapper/MapperServiceTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ public void testTypeValidation() {
9292
}
9393

9494
public void testGetMetadataFieldsReturnsExpectedSet() throws Throwable {
95-
final MapperService mapperService = createIndex("test1").mapperService();
96-
assertEquals(mapperService.getMetadataFields(), IndicesModule.getBuiltInMetadataFields());
95+
final IndexService indexService = createIndex("test1");
96+
assertEquals(indexService.getMetadataFields(), IndicesModule.getBuiltInMetadataFields());
9797
}
9898

9999
public void testPreflightUpdateDoesNotChangeMapping() throws Throwable {

0 commit comments

Comments
 (0)