refactor code

Signed-off-by: Anshu Agarwal <[email protected]>

Author: Anshu Agarwal

server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteRestoreSnapshotIT.java

@@ -800,41 +800,4 @@ public void testCentralizedCreateAndRestoreShallowCopy() throws Exception {
         assertDocsPresentInIndex(client(), restoredIndexName1, numDocsInIndex1);
     }
 
-    public void testCentralizedCreate() throws Exception {
-
-        Settings snapshotSettings = Settings.builder().put("snapshot.centralized_create_operation", true).build();
-        internalCluster().startClusterManagerOnlyNode(Settings.builder().put(snapshotSettings).build());
-        internalCluster().startDataOnlyNode(Settings.builder().put(snapshotSettings).build());
-        String indexName1 = "testindex1";
-        String indexName2 = "testindex2";
-        String snapshotRepoName = "test-create-snapshot-repo";
-        String snapshotName1 = "test-create-snapshot1";
-        Path absolutePath1 = randomRepoPath().toAbsolutePath();
-        logger.info("Snapshot Path [{}]", absolutePath1);
-        String restoredIndexName1 = indexName1 + "-restored";
-
-        createRepository(snapshotRepoName, "fs", getRepositorySettings(absolutePath1, true));
-
-        Client client = client();
-        Settings indexSettings = getIndexSettings(20, 0).build();
-        createIndex(indexName1, indexSettings);
-
-        Settings indexSettings2 = getIndexSettings(15, 0).build();
-        createIndex(indexName2, indexSettings2);
-
-        final int numDocsInIndex1 = 10;
-        final int numDocsInIndex2 = 20;
-        indexDocuments(client, indexName1, numDocsInIndex1);
-        indexDocuments(client, indexName2, numDocsInIndex2);
-        ensureGreen(indexName1, indexName2);
-
-        internalCluster().startDataOnlyNode(Settings.builder().put(snapshotSettings).build());
-        logger.info("--> snapshot");
-
-        SnapshotInfo snapshotInfo = createSnapshot(snapshotRepoName, snapshotName1, new ArrayList<>(Arrays.asList(indexName1, indexName2)));
-        assertThat(snapshotInfo.state(), equalTo(SnapshotState.SUCCESS));
-        assertThat(snapshotInfo.successfulShards(), greaterThan(0));
-        assertThat(snapshotInfo.successfulShards(), equalTo(snapshotInfo.totalShards()));
-
-
-    }
+}

server/src/main/java/org/opensearch/snapshots/SnapshotsService.java

@@ -685,11 +685,11 @@ public void onFailure(final Exception e) {
             }
         }, batch.size());
         for (Map.Entry<IndexId, Map<ShardId, ShardSnapshotStatus>> entry : batch) {
-            processIndexShards(snapshot, snapshotIdStr, entry.getKey(), entry.getValue(), finalListener);
+            snapshotIndexShards(snapshot, snapshotIdStr, entry.getKey(), entry.getValue(), finalListener);
         }
     }
 
-    private void processIndexShards(
+    private void snapshotIndexShards(
         Snapshot snapshot,
         String snapshotIdStr,
         IndexId indexId,
@@ -719,11 +719,11 @@ public void onFailure(final Exception e) {
             }
         }, shardStatusMap.size());
         for (Map.Entry<ShardId, ShardSnapshotStatus> entry : shardStatusMap.entrySet()) {
-            processShardAndUpload(snapshot, snapshotIdStr, indexId, entry.getKey(), entry.getValue(), shardListener);
+            snapshotShards(snapshot, snapshotIdStr, indexId, entry.getKey(), entry.getValue(), shardListener);
         }
     }
 
-    private void processShardAndUpload(
+    private void snapshotShards(
         Snapshot snapshot,
         String snapshotIdStr,
         IndexId indexId,