Refactor; gradle check fixes

Signed-off-by: Rishabh Maurya <[email protected]>

Author: rishabhmaurya

plugins/arrow-flight-rpc/build.gradle

@@ -14,7 +14,7 @@ apply plugin: 'opensearch.internal-cluster-test'
 opensearchplugin {
   description = 'Arrow flight based transport and stream implementation. It also provides Arrow vector and memory dependencies as' +
     'an extended-plugin at runtime; consumers should take a compile time dependency and not runtime on this project.\'\n'
-  classname = 'org.opensearch.arrow.flight.bootstrap.FlightStreamPlugin'
+  classname = 'org.opensearch.arrow.flight.transport.FlightStreamPlugin'
 }
 
 dependencies {

plugins/arrow-flight-rpc/src/internalClusterTest/java/org/opensearch/arrow/flight/ArrowFlightServerIT.java

@@ -19,7 +19,7 @@
 import org.apache.arrow.vector.VectorSchemaRoot;
 import org.opensearch.arrow.flight.bootstrap.FlightClientManager;
 import org.opensearch.arrow.flight.bootstrap.FlightService;
-import org.opensearch.arrow.flight.bootstrap.FlightStreamPlugin;
+import org.opensearch.arrow.flight.transport.FlightStreamPlugin;
 import org.opensearch.arrow.spi.StreamManager;
 import org.opensearch.arrow.spi.StreamProducer;
 import org.opensearch.arrow.spi.StreamReader;

plugins/arrow-flight-rpc/src/internalClusterTest/java/org/opensearch/arrow/flight/FlightTransportIT.java

@@ -14,17 +14,15 @@
 import org.opensearch.action.bulk.BulkRequest;
 import org.opensearch.action.bulk.BulkResponse;
 import org.opensearch.action.index.IndexRequest;
-import org.opensearch.action.search.SearchRequest;
 import org.opensearch.action.search.SearchResponse;
-import org.opensearch.arrow.flight.bootstrap.FlightStreamPlugin;
+import org.opensearch.arrow.flight.transport.FlightStreamPlugin;
 import org.opensearch.common.action.ActionFuture;
 import org.opensearch.common.settings.Settings;
 import org.opensearch.common.unit.TimeValue;
 import org.opensearch.common.xcontent.XContentType;
 import org.opensearch.plugins.Plugin;
 import org.opensearch.search.SearchHit;
 import org.opensearch.test.OpenSearchIntegTestCase;
-import org.junit.BeforeClass;
 
 import java.util.Collection;
 import java.util.Collections;
@@ -39,14 +37,6 @@ protected Collection<Class<? extends Plugin>> nodePlugins() {
         return Collections.singleton(FlightStreamPlugin.class);
     }
 
-    @BeforeClass
-    public static void setupSysProperties() {
-        System.setProperty("io.netty.allocator.numDirectArenas", "1");
-        System.setProperty("io.netty.noUnsafe", "false");
-        System.setProperty("io.netty.tryUnsafe", "true");
-        System.setProperty("io.netty.tryReflectionSetAccessible", "true");
-    }
-
     @Override
     public void setUp() throws Exception {
         super.setUp();

plugins/arrow-flight-rpc/src/main/java/org/opensearch/arrow/flight/bootstrap/FlightService.java

@@ -36,6 +36,8 @@
  * FlightService manages the Arrow Flight server and client for OpenSearch.
  * It handles the initialization, startup, and shutdown of the Flight server and client,
  * as well as managing the stream operations through a FlightStreamManager.
+ *
+ * @opensearch.internal
  */
 public class FlightService extends AuxTransport {
     /**
@@ -71,24 +73,44 @@ public String settingKey() {
         return ARROW_FLIGHT_TRANSPORT_SETTING_KEY;
     }
 
-    void setClusterService(ClusterService clusterService) {
+    /**
+     * Sets the cluster service for the Flight service.
+     * @param clusterService The cluster service instance
+     */
+    public void setClusterService(ClusterService clusterService) {
         serverComponents.setClusterService(Objects.requireNonNull(clusterService, "ClusterService cannot be null"));
     }
 
-    void setNetworkService(NetworkService networkService) {
+    /**
+     * Sets the network service for the Flight service.
+     * @param networkService The network service instance
+     */
+    public void setNetworkService(NetworkService networkService) {
         serverComponents.setNetworkService(Objects.requireNonNull(networkService, "NetworkService cannot be null"));
     }
 
-    void setThreadPool(ThreadPool threadPool) {
+    /**
+     * Sets the thread pool for the Flight service.
+     * @param threadPool The thread pool instance
+     */
+    public void setThreadPool(ThreadPool threadPool) {
         this.threadPool = Objects.requireNonNull(threadPool, "ThreadPool cannot be null");
         serverComponents.setThreadPool(threadPool);
     }
 
-    void setClient(Client client) {
+    /**
+     * Sets the client for the Flight service.
+     * @param client The client instance
+     */
+    public void setClient(Client client) {
         this.client = client;
     }
 
-    void setSecureTransportSettingsProvider(SecureTransportSettingsProvider secureTransportSettingsProvider) {
+    /**
+     * Sets the secure transport settings provider for the Flight service.
+     * @param secureTransportSettingsProvider The secure transport settings provider
+     */
+    public void setSecureTransportSettingsProvider(SecureTransportSettingsProvider secureTransportSettingsProvider) {
         this.secureTransportSettingsProvider = secureTransportSettingsProvider;
     }
 

plugins/arrow-flight-rpc/src/main/java/org/opensearch/arrow/flight/bootstrap/ServerComponents.java

@@ -52,30 +52,47 @@
 import static org.opensearch.transport.AuxTransport.AUX_TRANSPORT_PORT;
 import static org.opensearch.transport.Transport.resolveTransportPublishPort;
 
+/**
+ * Server components for Arrow Flight RPC integration with OpenSearch.
+ * Manages the lifecycle of Flight server instances and their configuration.
+ * @opensearch.internal
+ */
 @SuppressWarnings("removal")
 public final class ServerComponents implements AutoCloseable {
 
+    /**
+     * Setting for Arrow Flight host addresses.
+     */
     public static final Setting<List<String>> SETTING_FLIGHT_HOST = listSetting(
         "arrow.flight.host",
         emptyList(),
         Function.identity(),
         Setting.Property.NodeScope
     );
 
+    /**
+     * Setting for Arrow Flight bind host addresses.
+     */
     public static final Setting<List<String>> SETTING_FLIGHT_BIND_HOST = listSetting(
         "arrow.flight.bind_host",
         SETTING_FLIGHT_HOST,
         Function.identity(),
         Setting.Property.NodeScope
     );
 
+    /**
+     * Setting for Arrow Flight publish host addresses.
+     */
     public static final Setting<List<String>> SETTING_FLIGHT_PUBLISH_HOST = listSetting(
         "arrow.flight.publish_host",
         SETTING_FLIGHT_HOST,
         Function.identity(),
         Setting.Property.NodeScope
     );
 
+    /**
+     * Setting for Arrow Flight publish port.
+     */
     public static final Setting<Integer> SETTING_FLIGHT_PUBLISH_PORT = intSetting(
         "arrow.flight.publish_port",
         -1,
@@ -89,7 +106,14 @@ public final class ServerComponents implements AutoCloseable {
     private static final String GRPC_BOSS_ELG = "os-grpc-boss-ELG";
     private static final int SHUTDOWN_TIMEOUT_SECONDS = 5;
 
+    /**
+     * The setting key for Flight transport configuration.
+     */
     public static final String FLIGHT_TRANSPORT_SETTING_KEY = "transport-flight";
+
+    /**
+     * Setting for Arrow Flight port range.
+     */
     public static final Setting<PortsRange> SETTING_FLIGHT_PORTS = AUX_TRANSPORT_PORT.getConcreteSettingForNamespace(
         FLIGHT_TRANSPORT_SETTING_KEY
     );

plugins/arrow-flight-rpc/src/main/java/org/opensearch/arrow/flight/bootstrap/ServerConfig.java

@@ -35,6 +35,7 @@
  * Configuration class for OpenSearch Flight server settings.
  * This class manages server-side configurations including port settings, Arrow memory settings,
  * thread pool configurations, and SSL/TLS settings.
+ * @opensearch.internal
  */
 public class ServerConfig {
     /**
@@ -182,10 +183,20 @@ static EventLoopGroup createELG(String name, int eventLoopThreads) {
             : new NioEventLoopGroup(eventLoopThreads, OpenSearchExecutors.daemonThreadFactory(name));
     }
 
+    /**
+     * Returns the appropriate server channel type based on platform availability.
+     *
+     * @return EpollServerSocketChannel if Epoll is available, otherwise NioServerSocketChannel
+     */
     public static Class<? extends Channel> serverChannelType() {
         return Epoll.isAvailable() ? EpollServerSocketChannel.class : NioServerSocketChannel.class;
     }
 
+    /**
+     * Returns the appropriate client channel type based on platform availability.
+     *
+     * @return EpollSocketChannel if Epoll is available, otherwise NioSocketChannel
+     */
     public static Class<? extends Channel> clientChannelType() {
         return Epoll.isAvailable() ? EpollSocketChannel.class : NioSocketChannel.class;
     }