Fix issue of red index on close for remote enabled clusters

Signed-off-by: Ashish Singh <[email protected]>

Author: ashking94

server/src/main/java/org/opensearch/action/admin/indices/close/TransportVerifyShardBeforeCloseAction.java

@@ -160,7 +160,7 @@ private void executeShardOperation(final ShardRequest request, final IndexShard
             // to the primary (we call this phase1), and phase2 can then use the fact that the global checkpoint has moved to the maximum
             // sequence number to pass the verifyShardBeforeIndexClosing check and create a safe commit where the maximum sequence number
             // is equal to the global checkpoint.
-            indexShard.sync();
+            indexShard.sync(true);
         } else {
             indexShard.verifyShardBeforeIndexClosing();
             indexShard.flush(new FlushRequest().force(true).waitIfOngoing(true));

server/src/main/java/org/opensearch/index/shard/IndexShard.java

@@ -4507,8 +4507,12 @@ public final void sync(Translog.Location location, Consumer<Exception> syncListe
     }
 
     public void sync() throws IOException {
+        sync(false);
+    }
+
+    public void sync(boolean force) throws IOException {
         verifyNotClosed();
-        getEngine().translogManager().syncTranslog();
+        getEngine().translogManager().syncTranslog(force);
     }
 
     /**

server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java

@@ -195,7 +195,12 @@ public boolean ensureTranslogSynced(Stream<Translog.Location> locations) throws
      */
     @Override
     public void syncTranslog() throws IOException {
-        translog.sync();
+        syncTranslog(false);
+    }
+
+    @Override
+    public void syncTranslog(boolean force) throws IOException {
+        translog.sync(force);
         translogEventListener.onAfterTranslogSync();
     }
 

server/src/main/java/org/opensearch/index/translog/NoOpTranslogManager.java

@@ -72,6 +72,9 @@ public boolean ensureTranslogSynced(Stream<Translog.Location> locations) {
     @Override
     public void syncTranslog() throws IOException {}
 
+    @Override
+    public void syncTranslog(boolean force) throws IOException {}
+
     @Override
     public TranslogStats getTranslogStats() {
         return translogStats;

server/src/main/java/org/opensearch/index/translog/RemoteFsTranslog.java

@@ -463,7 +463,12 @@ private boolean syncToDisk() throws IOException {
 
     @Override
     public void sync() throws IOException {
-        if (syncToDisk() || syncNeeded()) {
+        sync(false);
+    }
+
+    @Override
+    public void sync(boolean force) throws IOException {
+        if (syncToDisk() || syncNeeded() || force) {
             prepareAndUpload(primaryTermSupplier.getAsLong(), null);
         }
     }

server/src/main/java/org/opensearch/index/translog/Translog.java

@@ -751,6 +751,13 @@ private Closeable acquireTranslogGenFromDeletionPolicy(long viewGen) {
      * Sync's the translog.
      */
     public void sync() throws IOException {
+        sync(false);
+    }
+
+    /**
+     * Sync's the translog.
+     */
+    public void sync(boolean ignored) throws IOException {
         try (ReleasableLock lock = readLock.acquire()) {
             if (closed.get() == false) {
                 current.sync();

server/src/main/java/org/opensearch/index/translog/TranslogManager.java

@@ -58,6 +58,12 @@ public interface TranslogManager {
      */
     void syncTranslog() throws IOException;
 
+    /**
+     * Syncs translog with option to force sync
+     * @throws IOException the exception while performing the sync operation
+     */
+    void syncTranslog(boolean force) throws IOException;
+
     /**
      * Translog operation stats
      * @return the translog stats