Skip to content

Commit 1394c39

Browse files
author
Shailesh Singh
committed
address comments - change Collection.ncopies to a for loop
1 parent fa447c8 commit 1394c39

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

server/src/main/java/org/opensearch/index/compositeindex/datacube/NumericDimension.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,4 @@ public boolean equals(Object o) {
7777
public int hashCode() {
7878
return Objects.hash(field);
7979
}
80-
8180
}

server/src/main/java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,9 @@ protected BaseStarTreeBuilder(
139139
int numDims = 0;
140140
for (Dimension dim : starTreeField.getDimensionsOrder()) {
141141
numDims += dim.getNumSubDimensions();
142-
dimensionComparators.addAll(Collections.nCopies(dim.getNumSubDimensions(), dim.comparator()));
142+
for (int i = 0; i < dim.getNumSubDimensions(); i++) {
143+
dimensionComparators.add(dim.comparator());
144+
}
143145
dimensionsSplitOrder.add(dim);
144146
}
145147
this.numDimensions = numDims;

0 commit comments

Comments
 (0)