Skip to content

Conversation

@jacobo-dominguez-wgu
Copy link

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Oct 7, 2025

Description

This PR is intended to convert the whole codebase to work with frontend-base.
Full description: openedx/frontend-app-account#1316

Features dropped on the conversion:

  • react-helmet
  • Optimizely

TODO:

Warning

With the migration to frontend-base we have noticed the api calls have significantly increased and may cause performance issues, in account-mfe openedx/frontend-app-account#1325 this was fixed by migrating redux sagas and thunks to react-query, but this is an incident that needs to be investigated and fixed in the frontend-base codebase. This project still has this problem.

Testing Instructions

  • Setup your local to run frontend-base apps following this guide.
  • Clean all your node_modules rm -rf node_modules and reinstall them npm ci
  • Run the dev server npm run dev

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 7, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 7, 2025
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Oct 8, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 8, 2025
Copy link
Author

@jacobo-dominguez-wgu jacobo-dominguez-wgu Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbrandes , @brian-smith-tcril This is the one with the issue I mentioned related to the broken image L23.

.profile-page-bg-banner {
  height: 12rem;
  background-image: url('./assets/dot-pattern-light.png');
  background-repeat: repeat-x;
  background-size: auto 85%;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: No status
Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants