-
Notifications
You must be signed in to change notification settings - Fork 134
Frontend base conversion #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: frontend-base
Are you sure you want to change the base?
Frontend base conversion #1280
Conversation
…n-edX/frontend-app-profile into frontend-base-conversion
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arbrandes , @brian-smith-tcril This is the one with the issue I mentioned related to the broken image L23.
.profile-page-bg-banner {
height: 12rem;
background-image: url('./assets/dot-pattern-light.png');
background-repeat: repeat-x;
background-size: auto 85%;
}
Description
This PR is intended to convert the whole codebase to work with frontend-base.
Full description: openedx/frontend-app-account#1316
Features dropped on the conversion:
TODO:
Warning
With the migration to frontend-base we have noticed the api calls have significantly increased and may cause performance issues, in account-mfe openedx/frontend-app-account#1325 this was fixed by migrating redux sagas and thunks to react-query, but this is an incident that needs to be investigated and fixed in the frontend-base codebase. This project still has this problem.
Testing Instructions
rm -rf node_modulesand reinstall themnpm cinpm run dev