Skip to content

Conversation

@jacobo-dominguez-wgu
Copy link

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Aug 14, 2025

Description

Whole codebase refactor to work with frontend-base.
Full description: #1316

Dropped features:

  • react-helmet
  • Optimizely

In addition to frontend-base refactor the next features were also modified

  • Class components turned into functional components.
  • All new files were created as typescript files.
  • Removal of injectIntl and replaced with useIntl hook.
  • Snapshot tests were replaced with jest/rtl user centric tests.
  • Redux-saga was causing an api refetching issue, so all the redux ecosystem including redux, sagas, thunk, reselect were replaced with react-query, the next dependencies were removed:
    • redux
    • react-redux
    • redux-devtools-extension
    • redux-logger
    • redux-saga
    • redux-thunk
    • reselect

Testing

Considering all the changes this pr involves, a thorough testing session is required to verify it perfectly works with frontend base and the new global storage system from react query.
I have tested most of the sections of the accounts settings and seem to work fine but I could not find the natural way to enable some fields as the third auth providers, notification settings and verified name which are hidden under certain conditionals, so special and intensive testing is required on those fields.

Testing Instructions

  • Setup your local to run frontend-base apps following this guide.
  • Clean all your node_modules rm -rf node_modules and reinstall them npm ci
  • Run the dev server npm run dev

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 14, 2025

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 14, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 14, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu changed the title Frontend base migration WIP: Frontend base migration Aug 14, 2025
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Aug 21, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 21, 2025
@mphilbrick211
Copy link

Hi @jacobo-dominguez-wgu! Just checking in to see if this is still in progress?

@jacobo-dominguez-wgu
Copy link
Author

Hi @jacobo-dominguez-wgu! Just checking in to see if this is still in progress?

Hi @mphilbrick211 , yes I am still working on this one, I wanted to turn the PR into a draft but I did not see the option.

@jacobo-dominguez-wgu jacobo-dominguez-wgu changed the title WIP: Frontend base migration Frontend base migration Sep 22, 2025
@arbrandes arbrandes changed the title Frontend base migration Convert Account to frontend-base Sep 24, 2025
@arbrandes arbrandes self-requested a review September 24, 2025 19:20
@arbrandes arbrandes mentioned this pull request Sep 25, 2025
10 tasks
@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Waiting on Author to Ready for Review in Contributions Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants