-
Notifications
You must be signed in to change notification settings - Fork 166
Convert Account to frontend-base #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: frontend-base
Are you sure you want to change the base?
Convert Account to frontend-base #1325
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @jacobo-dominguez-wgu! Just checking in to see if this is still in progress? |
Hi @mphilbrick211 , yes I am still working on this one, I wanted to turn the PR into a draft but I did not see the option. |
Description
Whole codebase refactor to work with frontend-base.
Full description: #1316
Dropped features:
In addition to frontend-base refactor the next features were also modified
injectIntland replaced withuseIntlhook.Testing
Considering all the changes this pr involves, a thorough testing session is required to verify it perfectly works with frontend base and the new global storage system from react query.
I have tested most of the sections of the accounts settings and seem to work fine but I could not find the natural way to enable some fields as the third auth providers, notification settings and verified name which are hidden under certain conditionals, so special and intensive testing is required on those fields.
Testing Instructions
rm -rf node_modulesand reinstall themnpm cinpm run dev