Exclusion feature #117
Merged
Exclusion feature #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsauter
force-pushed
the
feature/exclude
branch
2 times, most recently
from
129ad6b to
e0fe355
Compare
michaelsauter
force-pushed
the
feature/exclude
branch
from
e0fe355 to
18f17a4
Compare
henrjk
reviewed
Jul 19, 2019
Member
henrjk
left a comment
henrjk
left a comment
There was a problem hiding this comment.
I added some review comments. A few of them might need additional work. Please have a look.
Member
|
Somehow the button were I could approve my review is no longer available to me. |
henrjk
approved these changes
Jul 19, 2019
Member
Author
|
@henrjk Thanks for all the feedback. With regards to the button: I always have the same issue. You can go to "Files changes" tab, there click "Review changes" and then you can approve. At least that is my workaround ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115.