Skip to content

Conversation

@zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Apr 13, 2017

According to the shared subtree.

Signed-off-by: zhouhao [email protected]

@wking
Copy link
Contributor

wking commented Apr 13, 2017 via email

@wking
Copy link
Contributor

wking commented Apr 13, 2017

Looks like the JSON Schema could also use an enum.

@zhouhao3
Copy link
Author

@wking But why not use unbindable?

@wking
Copy link
Contributor

wking commented Apr 14, 2017

But why not use unbindable?

unbindable is good with me. I just though "change" was an odd choice of words for a feature from 2005 ;). The enum entry should update the entry in config-linux.json.

@mrunalp
Copy link
Contributor

mrunalp commented Apr 18, 2017

LGTM

Approved with PullApprove

@zhouhao3
Copy link
Author

@hqhq @vbatts PTAL

@zhouhao3
Copy link
Author

@crosbymichael PTAL

@crosbymichael
Copy link
Member

crosbymichael commented Apr 25, 2017

LGTM

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants