Skip to content

Commit 7b500a3

Browse files
author
Mrunal Patel
authored
Merge pull request #1243 from cyphar/govet-cleanup
*: fix go-vet failures
2 parents c441a2f + 816efe0 commit 7b500a3

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

libcontainer/integration/exec_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ func testExecPS(t *testing.T, userns bool) {
3939
defer remove(rootfs)
4040
config := newTemplateConfig(rootfs)
4141
if userns {
42-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
43-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
42+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
43+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
4444
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
4545
}
4646

@@ -181,8 +181,8 @@ func testRlimit(t *testing.T, userns bool) {
181181

182182
config := newTemplateConfig(rootfs)
183183
if userns {
184-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
185-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
184+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
185+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
186186
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
187187
}
188188

@@ -1565,8 +1565,8 @@ func TestInitJoinNetworkAndUser(t *testing.T) {
15651565

15661566
// Execute a long-running container
15671567
config1 := newTemplateConfig(rootfs)
1568-
config1.UidMappings = []configs.IDMap{{0, 0, 1000}}
1569-
config1.GidMappings = []configs.IDMap{{0, 0, 1000}}
1568+
config1.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
1569+
config1.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
15701570
config1.Namespaces = append(config1.Namespaces, configs.Namespace{Type: configs.NEWUSER})
15711571
container1, err := newContainer(config1)
15721572
ok(t, err)
@@ -1597,8 +1597,8 @@ func TestInitJoinNetworkAndUser(t *testing.T) {
15971597
defer remove(rootfs2)
15981598

15991599
config2 := newTemplateConfig(rootfs2)
1600-
config2.UidMappings = []configs.IDMap{{0, 0, 1000}}
1601-
config2.GidMappings = []configs.IDMap{{0, 0, 1000}}
1600+
config2.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
1601+
config2.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
16021602
config2.Namespaces.Add(configs.NEWNET, netns1)
16031603
config2.Namespaces.Add(configs.NEWUSER, userns1)
16041604
config2.Cgroups.Path = "integration/test2"

libcontainer/integration/execin_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ func testExecInRlimit(t *testing.T, userns bool) {
8989

9090
config := newTemplateConfig(rootfs)
9191
if userns {
92-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
93-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
92+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
93+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
9494
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
9595
}
9696

@@ -503,8 +503,8 @@ func TestExecInUserns(t *testing.T) {
503503
ok(t, err)
504504
defer remove(rootfs)
505505
config := newTemplateConfig(rootfs)
506-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
507-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
506+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
507+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
508508
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
509509
container, err := newContainer(config)
510510
ok(t, err)

0 commit comments

Comments
 (0)