Cleanup still remaining __pycache__ and *.egg-info directories and fix typo in README #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sbera77
changed the title
sbera77
changed the title
Contributor
Author
|
@rm-openai Could you please review this PR when you have time? Thanks! |
Collaborator
|
I'm taking care of this separately - appreciate the PR though! |
DeanLuus22021994
pushed a commit
to DeanLuus22021994/openai-agents-python
that referenced
this pull request
Nov 8, 2025
HIGH PRIORITY openai#4 - Docker Compose Profile Configuration Fixed Changes: - Fixed devcontainer.json: 'app' 'app-dev' service reference - Updated runServices to match docker-compose.yml services - Added Docker Compose Profiles section to README.md Profile Documentation: - dev (default): Development environment with hot reload - prod: Production deployment with resource limits - actors: Enables Dapr Placement service for actors/workflows VS Code Integration: - Tasks already configured for all profiles - DevContainer now correctly references app-dev service - All services (app-dev, redis, postgres, dapr-sidecar) properly defined Verification: - Current stack running with correct app-dev service - All 4 containers healthy and running - DevContainer configuration now matches docker-compose.yml
DeanLuus22021994
pushed a commit
to DeanLuus22021994/openai-agents-python
that referenced
this pull request
Nov 8, 2025
- Add missing methods to ContainerService base class (add_port, set_health_check, add_environment, add_volume) - Create concrete implementations for RedisService and PostgresService - Fix ServiceFactory to use correct imports and implementations - Update all module imports to use new directory structure - Add health_check, command, and profiles instance variables - Ensure compose config includes all necessary fields - Remove app-dev profile restriction for DevContainer compatibility HIGH PRIORITY openai#3 & openai#4 progress: - Verified all documented classes exist and work - Fixed docker-compose profile configuration - All infrastructure Python files now properly implemented
DeanLuus22021994
pushed a commit
to DeanLuus22021994/openai-agents-python
that referenced
this pull request
Nov 8, 2025
Updated .devcontainerPLAN.md with: - HIGH PRIORITY openai#3 completion details (Infrastructure Implementation) * Implementation summary with all fixes and additions * Test suite results (all tests passed) * Class verification checklist * Actual effort: 3 hours (vs 4-6h estimated) * Commits: a7f74f7, 64b89f7 - HIGH PRIORITY openai#4 completion details (Docker Compose Profiles) * Fixed docker-compose.yml (removed app-dev profile restriction) * Verified devcontainer.json already correct * Documented existing profile documentation and tasks * Actual effort: 0.5 hours (vs 1-2h estimated) * Commits: a7f74f7, 816fa06 - Updated effort summary: * Total HIGH PRIORITY: 5.5 hours actual vs 9-14 hours estimated * Efficiency: 61% better than estimated * Overall progress: 31% complete (4/13 items) All HIGH PRIORITY items (4/4) now complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed pycache and *.egg-info directories