Add changelog and fix lint

Author: ocelotl

CHANGELOG.md

@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - When encountering an error encoding metric attributes in the OTLP exporter, log the key that had an error.
   ([#3838](https://github.com/open-telemetry/opentelemetry-python/pull/3838))
+- Fix `ExponentialHistogramAggregation`
+  ([#3978](https://github.com/open-telemetry/opentelemetry-python/pull/3978))
 - Log a warning when a `LogRecord` in `sdk/log` has dropped attributes
   due to reaching limits
   ([#3946](https://github.com/open-telemetry/opentelemetry-python/pull/3946))

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py

@@ -298,9 +298,7 @@ def collect(
                 if value is None:
                     value = 0
 
-                self._previous_value = (
-                    value + self._previous_value
-                )
+                self._previous_value = value + self._previous_value
 
                 return NumberDataPoint(
                     attributes=self._attributes,
@@ -498,9 +496,7 @@ def collect(
                     value = self._get_empty_bucket_counts()
 
                 if self._previous_value is None:
-                    self._previous_value = (
-                        self._get_empty_bucket_counts()
-                    )
+                    self._previous_value = self._get_empty_bucket_counts()
 
                 self._previous_value = [
                     value_element + previous_value_element
@@ -644,7 +640,7 @@ def aggregate(self, measurement: Measurement) -> None:
 
                 return
 
-            elif measurement_value > 0:
+            if measurement_value > 0:
                 value = self._value_positive
 
             else:
@@ -768,10 +764,7 @@ def collect(
                     is AggregationTemporality.DELTA
                 ):
 
-                    if (
-                        value_positive is None and
-                        value_negative is None
-                    ):
+                    if value_positive is None and value_negative is None:
                         return None
 
                     previous_collection_start_nano = (
@@ -791,15 +784,11 @@ def collect(
                         zero_count=zero_count,
                         positive=BucketsPoint(
                             offset=value_positive.offset,
-                            bucket_counts=(
-                                value_positive.get_offset_counts()
-                            ),
+                            bucket_counts=(value_positive.get_offset_counts()),
                         ),
                         negative=BucketsPoint(
                             offset=value_negative.offset,
-                            bucket_counts=(
-                                value_negative.get_offset_counts()
-                            ),
+                            bucket_counts=(value_negative.get_offset_counts()),
                         ),
                         # FIXME: Find the right value for flags
                         flags=0,
@@ -820,30 +809,26 @@ def collect(
                 # to the current buckets).
 
                 if (
-                    value_positive is None and
-                    self._previous_value_positive is None
+                    value_positive is None
+                    and self._previous_value_positive is None
                 ):
                     # This happens if collect is called for the first time
                     # and aggregate has not yet been called.
                     value_positive = Buckets()
-                    self._previous_value_positive = (
-                        value_positive.copy_empty()
-                    )
+                    self._previous_value_positive = value_positive.copy_empty()
                 if (
-                    value_negative is None and
-                    self._previous_value_negative is None
+                    value_negative is None
+                    and self._previous_value_negative is None
                 ):
                     value_negative = Buckets()
-                    self._previous_value_negative = (
-                        value_negative.copy_empty()
-                    )
+                    self._previous_value_negative = value_negative.copy_empty()
                 if scale is None and self._previous_scale is None:
                     scale = self._mapping.scale
                     self._previous_scale = scale
 
                 if (
-                    value_positive is not None and
-                    self._previous_value_positive is None
+                    value_positive is not None
+                    and self._previous_value_positive is None
                 ):
                     # This happens when collect is called the very first time
                     # and aggregate has been called before.
@@ -864,33 +849,25 @@ def collect(
                     # ones resulting in the current ones unchanged we need to
                     # generate empty buckets that have the same size and amount
                     # as the current ones, this is what copy_empty does.
-                    self._previous_value_positive = (
-                        value_positive.copy_empty()
-                    )
+                    self._previous_value_positive = value_positive.copy_empty()
                 if (
-                    value_negative is not None and
-                    self._previous_value_negative is None
+                    value_negative is not None
+                    and self._previous_value_negative is None
                 ):
-                    self._previous_value_negative = (
-                        value_negative.copy_empty()
-                    )
+                    self._previous_value_negative = value_negative.copy_empty()
                 if scale is not None and self._previous_scale is None:
                     self._previous_scale = scale
 
                 if (
-                    value_positive is None and
-                    self._previous_value_positive is not None
+                    value_positive is None
+                    and self._previous_value_positive is not None
                 ):
-                    value_positive = (
-                        self._previous_value_positive.copy_empty()
-                    )
+                    value_positive = self._previous_value_positive.copy_empty()
                 if (
-                    value_negative is None and
-                    self._previous_value_negative is not None
+                    value_negative is None
+                    and self._previous_value_negative is not None
                 ):
-                    value_negative = (
-                        self._previous_value_negative.copy_empty()
-                    )
+                    value_negative = self._previous_value_negative.copy_empty()
                 if scale is None and self._previous_scale is not None:
                     scale = self._previous_scale
 
@@ -971,17 +948,13 @@ def collect(
                     positive=BucketsPoint(
                         offset=self._previous_value_positive.offset,
                         bucket_counts=(
-                            self.
-                            _previous_value_positive.
-                            get_offset_counts()
+                            self._previous_value_positive.get_offset_counts()
                         ),
                     ),
                     negative=BucketsPoint(
                         offset=self._previous_value_negative.offset,
                         bucket_counts=(
-                            self.
-                            _previous_value_negative.
-                            get_offset_counts()
+                            self._previous_value_negative.get_offset_counts()
                         ),
                     ),
                     # FIXME: Find the right value for flags

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/buckets.py

@@ -181,6 +181,10 @@ def increment_bucket(self, bucket_index: int, increment: int = 1) -> None:
     def copy_empty(self) -> "Buckets":
         copy = Buckets()
 
+        # pylint: disable=no-member
+        # pylint: disable=protected-access
+        # pylint: disable=attribute-defined-outside-init
+        # pylint: disable=invalid-name
         copy._Buckets__index_base = self._Buckets__index_base
         copy._Buckets__index_start = self._Buckets__index_start
         copy._Buckets__index_end = self._Buckets__index_end