Skip to content

fix(instrumentation-net): Don't operate on closed span #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix(instrumentation-net): Don't operate on closed span #1819

merged 3 commits into from
Nov 27, 2023

Conversation

@mhennoch
Copy link
Contributor

@mhennoch mhennoch commented Nov 23, 2023

Fixes #1775

@mhennoch mhennoch requested a review from a team November 23, 2023 10:23
@codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

Merging #1819 (b6d9991) into main (71172e5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1819   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         143      143           
  Lines        7303     7303           
  Branches     1461     1461           
=======================================
  Hits         6677     6677           
  Misses        626      626
Files Coverage Δ
...lemetry-instrumentation-net/src/instrumentation.ts 98.13% <100.00%> (ø)

trentm
trentm approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pichlermarc pichlermarc merged commit 60d60d0 into open-telemetry:main Nov 27, 2023
@dyladan dyladan mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trentm trentm trentm approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

+1 more reviewer

@seemk seemk seemk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tls instrumentation in @opentelemetry/instrumentation-net tries to operate on closed span

4 participants

@mhennoch @trentm @seemk @pichlermarc