Add instrumentation for vertx-sql-client #8311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Apr 18, 2023
.../test/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxSqlClientTest.java
Show resolved
Hide resolved
| equalTo(NET_PEER_NAME, "localhost"), | ||
| equalTo(NET_PEER_PORT, port)))); | ||
| } | ||
| } |
There was a problem hiding this comment.
This could happen in another PR if you want, but it might be nice to see a second query issued from inside the callback in order to verify the span parentage (depth 2 instead of depth 1).
...o/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxSqlClientAttributesGetter.java
Outdated
Show resolved
Hide resolved
...pentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxSqlClientNetAttributesGetter.java
Outdated
Show resolved
Hide resolved
...pentelemetry/javaagent/instrumentation/vertx/v4_0/sql/QueryResultBuilderInstrumentation.java
Outdated
Show resolved
Hide resolved
| import io.vertx.sqlclient.SqlConnectOptions; | ||
|
|
||
| // Helper class for accessing virtual field on package private QueryExecutor class. | ||
| public class QueryExecutorUtil { |
| } | ||
| } else if (argument instanceof PromiseInternal) { | ||
| promiseInternal = (PromiseInternal) argument; | ||
| } |
There was a problem hiding this comment.
Looking forward to pattern matching in java one day...... 💤
.../io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/QueryExecutorInstrumentation.java
Show resolved
Hide resolved
trask
approved these changes
Apr 19, 2023
mateuszrzeszutek
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8292