Skip to content

Commit cdd18ab

Browse files
authored
Fix component name for stdouttrace (#7195)
The STDOUT exporter not a standardized type. Use the [semantic convention recommendation of a "language-defined name of the type"](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/registry/attributes/otel.md#otel-component-type).
1 parent ee6d57b commit cdd18ab

File tree

3 files changed

+41
-14
lines changed

3 files changed

+41
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ The next release will require at least [Go 1.24].
7171
### Fixed
7272

7373
- Fix `go.opentelemetry.io/otel/exporters/prometheus` to deduplicate suffixes if already present in metric name when UTF8 is enabled. (#7088)
74+
- Fix the `go.opentelemetry.io/otel/exporters/stdout/stdouttrace` self-observability component type and name. (#7195)
7475

7576
<!-- Released section -->
7677
<!-- Don't change this section unless doing release -->

exporters/stdout/stdouttrace/trace.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ import (
2323
"go.opentelemetry.io/otel/semconv/v1.36.0/otelconv"
2424
)
2525

26-
// otelComponentType is a name identifying the type of the OpenTelemetry component.
27-
const otelComponentType = "stdout_trace_exporter"
26+
// otelComponentType is a name identifying the type of the OpenTelemetry
27+
// component. It is not a standardized OTel component type, so it uses the
28+
// Go package prefixed type name to ensure uniqueness and identity.
29+
const otelComponentType = "go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter"
2830

2931
var zeroTime time.Time
3032

exporters/stdout/stdouttrace/trace_test.go

Lines changed: 36 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,12 @@ func TestSelfObservability(t *testing.T) {
286286
DataPoints: []metricdata.DataPoint[int64]{
287287
{
288288
Attributes: attribute.NewSet(
289-
semconv.OTelComponentName("stdout_trace_exporter/0"),
290-
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
289+
semconv.OTelComponentName(
290+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/0",
291+
),
292+
semconv.OTelComponentTypeKey.String(
293+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
294+
),
291295
),
292296
Value: 0,
293297
},
@@ -305,8 +309,12 @@ func TestSelfObservability(t *testing.T) {
305309
DataPoints: []metricdata.DataPoint[int64]{
306310
{
307311
Attributes: attribute.NewSet(
308-
semconv.OTelComponentName("stdout_trace_exporter/0"),
309-
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
312+
semconv.OTelComponentName(
313+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/0",
314+
),
315+
semconv.OTelComponentTypeKey.String(
316+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
317+
),
310318
),
311319
Value: 2,
312320
},
@@ -323,8 +331,12 @@ func TestSelfObservability(t *testing.T) {
323331
DataPoints: []metricdata.HistogramDataPoint[float64]{
324332
{
325333
Attributes: attribute.NewSet(
326-
semconv.OTelComponentName("stdout_trace_exporter/0"),
327-
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
334+
semconv.OTelComponentName(
335+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/0",
336+
),
337+
semconv.OTelComponentTypeKey.String(
338+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
339+
),
328340
),
329341
},
330342
},
@@ -368,8 +380,12 @@ func TestSelfObservability(t *testing.T) {
368380
DataPoints: []metricdata.DataPoint[int64]{
369381
{
370382
Attributes: attribute.NewSet(
371-
semconv.OTelComponentName("stdout_trace_exporter/1"),
372-
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
383+
semconv.OTelComponentName(
384+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/1",
385+
),
386+
semconv.OTelComponentTypeKey.String(
387+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
388+
),
373389
),
374390
Value: 0,
375391
},
@@ -387,8 +403,12 @@ func TestSelfObservability(t *testing.T) {
387403
DataPoints: []metricdata.DataPoint[int64]{
388404
{
389405
Attributes: attribute.NewSet(
390-
semconv.OTelComponentName("stdout_trace_exporter/1"),
391-
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
406+
semconv.OTelComponentName(
407+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/1",
408+
),
409+
semconv.OTelComponentTypeKey.String(
410+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
411+
),
392412
semconv.ErrorType(context.Canceled),
393413
),
394414
Value: 2,
@@ -406,8 +426,12 @@ func TestSelfObservability(t *testing.T) {
406426
DataPoints: []metricdata.HistogramDataPoint[float64]{
407427
{
408428
Attributes: attribute.NewSet(
409-
semconv.OTelComponentName("stdout_trace_exporter/1"),
410-
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
429+
semconv.OTelComponentName(
430+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/1",
431+
),
432+
semconv.OTelComponentTypeKey.String(
433+
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
434+
),
411435
semconv.ErrorType(context.Canceled),
412436
),
413437
},

0 commit comments

Comments
 (0)