[chore]: enable all rules of perfsprint

mmorel-35 · mmorel-35 · commit 29616adb5b0d · 2024-11-14T20:18:59.000+01:00
Signed-off-by: Matthieu MOREL &lt;matthieu.morel35@gmail.com&gt;
diff --git a/.golangci.yml b/.golangci.yml
@@ -157,11 +157,11 @@ linters-settings:
     ignore-words:
       - cancelled
   perfsprint:
-    err-error: false
-    errorf: false
+    err-error: true
+    errorf: true
     int-conversion: true
-    sprintf1: false
-    strconcat: false
+    sprintf1: true
+    strconcat: true
   revive:
     # Sets the default failure confidence.
     # This means that linting errors with less than 0.8 confidence will be ignored.
diff --git a/bridge/opencensus/internal/span.go b/bridge/opencensus/internal/span.go
@@ -128,5 +128,5 @@ func (s *Span) AddLink(l octrace.Link) {
 
 // String prints a string representation of this span.
 func (s *Span) String() string {
-	return fmt.Sprintf("span %s", s.otelSpan.SpanContext().SpanID().String())
+	return "span " + s.otelSpan.SpanContext().SpanID().String()
 }
diff --git a/codes/codes.go b/codes/codes.go
@@ -5,6 +5,7 @@ package codes // import "go.opentelemetry.io/otel/codes"
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"strconv"
 )
@@ -63,7 +64,7 @@ func (c *Code) UnmarshalJSON(b []byte) error {
 		return nil
 	}
 	if c == nil {
-		return fmt.Errorf("nil receiver passed to UnmarshalJSON")
+		return errors.New("nil receiver passed to UnmarshalJSON")
 	}
 
 	var x interface{}
diff --git a/exporters/otlp/otlpmetric/otlpmetricgrpc/exporter.go b/exporters/otlp/otlpmetric/otlpmetricgrpc/exporter.go
@@ -5,6 +5,7 @@ package otlpmetricgrpc // import "go.opentelemetry.io/otel/exporters/otlp/otlpme
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"sync"
 
@@ -114,7 +115,7 @@ func (e *Exporter) Shutdown(ctx context.Context) error {
 	return err
 }
 
-var errShutdown = fmt.Errorf("gRPC exporter is shutdown")
+var errShutdown = errors.New("gRPC exporter is shutdown")
 
 type shutdownClient struct{}
 
diff --git a/exporters/otlp/otlpmetric/otlpmetricgrpc/internal/oconf/options.go b/exporters/otlp/otlpmetric/otlpmetricgrpc/internal/oconf/options.go
@@ -111,7 +111,7 @@ func cleanPath(urlPath string, defaultPath string) string {
 		return defaultPath
 	}
 	if !path.IsAbs(tmp) {
-		tmp = fmt.Sprintf("/%s", tmp)
+		tmp = "/" + tmp
 	}
 	return tmp
 }
diff --git a/exporters/otlp/otlpmetric/otlpmetrichttp/client.go b/exporters/otlp/otlpmetric/otlpmetrichttp/client.go
@@ -305,7 +305,7 @@ func newResponseError(header http.Header, wrapped error) error {
 
 func (e retryableError) Error() string {
 	if e.err != nil {
-		return fmt.Sprintf("retry-able request failure: %s", e.err.Error())
+		return "retry-able request failure: " + e.err.Error()
 	}
 
 	return "retry-able request failure"
diff --git a/exporters/otlp/otlpmetric/otlpmetrichttp/exporter.go b/exporters/otlp/otlpmetric/otlpmetrichttp/exporter.go
@@ -5,6 +5,7 @@ package otlpmetrichttp // import "go.opentelemetry.io/otel/exporters/otlp/otlpme
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"sync"
 
@@ -114,7 +115,7 @@ func (e *Exporter) Shutdown(ctx context.Context) error {
 	return err
 }
 
-var errShutdown = fmt.Errorf("HTTP exporter is shutdown")
+var errShutdown = errors.New("HTTP exporter is shutdown")
 
 type shutdownClient struct{}
 
diff --git a/exporters/otlp/otlpmetric/otlpmetrichttp/internal/oconf/options.go b/exporters/otlp/otlpmetric/otlpmetrichttp/internal/oconf/options.go
@@ -111,7 +111,7 @@ func cleanPath(urlPath string, defaultPath string) string {
 		return defaultPath
 	}
 	if !path.IsAbs(tmp) {
-		tmp = fmt.Sprintf("/%s", tmp)
+		tmp = "/" + tmp
 	}
 	return tmp
 }
diff --git a/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.go b/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.go
@@ -98,7 +98,7 @@ func cleanPath(urlPath string, defaultPath string) string {
 		return defaultPath
 	}
 	if !path.IsAbs(tmp) {
-		tmp = fmt.Sprintf("/%s", tmp)
+		tmp = "/" + tmp
 	}
 	return tmp
 }
diff --git a/exporters/otlp/otlptrace/otlptracehttp/client.go b/exporters/otlp/otlptrace/otlptracehttp/client.go
@@ -327,7 +327,7 @@ func newResponseError(header http.Header, wrapped error) error {
 
 func (e retryableError) Error() string {
 	if e.err != nil {
-		return fmt.Sprintf("retry-able request failure: %s", e.err.Error())
+		return "retry-able request failure: " + e.err.Error()
 	}
 
 	return "retry-able request failure"
diff --git a/exporters/otlp/otlptrace/otlptracehttp/internal/otlpconfig/options.go b/exporters/otlp/otlptrace/otlptracehttp/internal/otlpconfig/options.go
@@ -98,7 +98,7 @@ func cleanPath(urlPath string, defaultPath string) string {
 		return defaultPath
 	}
 	if !path.IsAbs(tmp) {
-		tmp = fmt.Sprintf("/%s", tmp)
+		tmp = "/" + tmp
 	}
 	return tmp
 }
diff --git a/sdk/metric/exporter.go b/sdk/metric/exporter.go
@@ -5,14 +5,14 @@ package metric // import "go.opentelemetry.io/otel/sdk/metric"
 
 import (
 	"context"
-	"fmt"
+	"errors"
 
 	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 )
 
 // ErrExporterShutdown is returned if Export or Shutdown are called after an
 // Exporter has been Shutdown.
-var ErrExporterShutdown = fmt.Errorf("exporter is shutdown")
+var ErrExporterShutdown = errors.New("exporter is shutdown")
 
 // Exporter handles the delivery of metric data to external receivers. This is
 // the final component in the metric push pipeline.
diff --git a/sdk/metric/meter.go b/sdk/metric/meter.go
@@ -475,7 +475,7 @@ func (m *meter) RegisterCallback(f metric.Callback, insts ...metric.Observable)
 			validInstruments = append(validInstruments, inst)
 		default:
 			// Instrument external to the SDK.
-			return nil, fmt.Errorf("invalid observable: from different implementation")
+			return nil, errors.New("invalid observable: from different implementation")
 		}
 	}
 
diff --git a/sdk/metric/metricdata/metricdatatest/comparisons.go b/sdk/metric/metricdata/metricdatatest/comparisons.go
@@ -32,7 +32,7 @@ func equalResourceMetrics(a, b metricdata.ResourceMetrics, cfg config) (reasons
 		},
 	))
 	if r != "" {
-		reasons = append(reasons, fmt.Sprintf("ResourceMetrics ScopeMetrics not equal:\n%s", r))
+		reasons = append(reasons, "ResourceMetrics ScopeMetrics not equal:\n"+r)
 	}
 	return reasons
 }
@@ -56,7 +56,7 @@ func equalScopeMetrics(a, b metricdata.ScopeMetrics, cfg config) (reasons []stri
 		},
 	))
 	if r != "" {
-		reasons = append(reasons, fmt.Sprintf("ScopeMetrics Metrics not equal:\n%s", r))
+		reasons = append(reasons, "ScopeMetrics Metrics not equal:\n"+r)
 	}
 	return reasons
 }
@@ -172,7 +172,7 @@ func equalGauges[N int64 | float64](a, b metricdata.Gauge[N], cfg config) (reaso
 		},
 	))
 	if r != "" {
-		reasons = append(reasons, fmt.Sprintf("Gauge DataPoints not equal:\n%s", r))
+		reasons = append(reasons, "Gauge DataPoints not equal:\n"+r)
 	}
 	return reasons
 }
@@ -199,7 +199,7 @@ func equalSums[N int64 | float64](a, b metricdata.Sum[N], cfg config) (reasons [
 		},
 	))
 	if r != "" {
-		reasons = append(reasons, fmt.Sprintf("Sum DataPoints not equal:\n%s", r))
+		reasons = append(reasons, "Sum DataPoints not equal:\n"+r)
 	}
 	return reasons
 }
@@ -223,7 +223,7 @@ func equalHistograms[N int64 | float64](a, b metricdata.Histogram[N], cfg config
 		},
 	))
 	if r != "" {
-		reasons = append(reasons, fmt.Sprintf("Histogram DataPoints not equal:\n%s", r))
+		reasons = append(reasons, "Histogram DataPoints not equal:\n"+r)
 	}
 	return reasons
 }
@@ -264,7 +264,7 @@ func equalDataPoints[N int64 | float64](a, b metricdata.DataPoint[N], cfg config
 			},
 		))
 		if r != "" {
-			reasons = append(reasons, fmt.Sprintf("Exemplars not equal:\n%s", r))
+			reasons = append(reasons, "Exemplars not equal:\n"+r)
 		}
 	}
 	return reasons
@@ -318,7 +318,7 @@ func equalHistogramDataPoints[N int64 | float64](a, b metricdata.HistogramDataPo
 			},
 		))
 		if r != "" {
-			reasons = append(reasons, fmt.Sprintf("Exemplars not equal:\n%s", r))
+			reasons = append(reasons, "Exemplars not equal:\n"+r)
 		}
 	}
 	return reasons
@@ -343,7 +343,7 @@ func equalExponentialHistograms[N int64 | float64](a, b metricdata.ExponentialHi
 		},
 	))
 	if r != "" {
-		reasons = append(reasons, fmt.Sprintf("Histogram DataPoints not equal:\n%s", r))
+		reasons = append(reasons, "Histogram DataPoints not equal:\n"+r)
 	}
 	return reasons
 }
@@ -406,7 +406,7 @@ func equalExponentialHistogramDataPoints[N int64 | float64](a, b metricdata.Expo
 			},
 		))
 		if r != "" {
-			reasons = append(reasons, fmt.Sprintf("Exemplars not equal:\n%s", r))
+			reasons = append(reasons, "Exemplars not equal:\n"+r)
 		}
 	}
 	return reasons
@@ -432,7 +432,7 @@ func equalSummary(a, b metricdata.Summary, cfg config) (reasons []string) {
 		},
 	))
 	if r != "" {
-		reasons = append(reasons, fmt.Sprintf("Summary DataPoints not equal:\n%s", r))
+		reasons = append(reasons, "Summary DataPoints not equal:\n"+r)
 	}
 	return reasons
 }
@@ -634,7 +634,7 @@ func compareDiff[T any](extraExpected, extraActual []T) string {
 }
 
 func missingAttrStr(name string) string {
-	return fmt.Sprintf("missing attribute %s", name)
+	return "missing attribute " + name
 }
 
 func hasAttributesExemplars[T int64 | float64](exemplar metricdata.Exemplar[T], attrs ...attribute.KeyValue) (reasons []string) {
diff --git a/sdk/metric/reader.go b/sdk/metric/reader.go
@@ -5,26 +5,26 @@ package metric // import "go.opentelemetry.io/otel/sdk/metric"
 
 import (
 	"context"
-	"fmt"
+	"errors"
 
 	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 )
 
 // errDuplicateRegister is logged by a Reader when an attempt to registered it
 // more than once occurs.
-var errDuplicateRegister = fmt.Errorf("duplicate reader registration")
+var errDuplicateRegister = errors.New("duplicate reader registration")
 
 // ErrReaderNotRegistered is returned if Collect or Shutdown are called before
 // the reader is registered with a MeterProvider.
-var ErrReaderNotRegistered = fmt.Errorf("reader is not registered")
+var ErrReaderNotRegistered = errors.New("reader is not registered")
 
 // ErrReaderShutdown is returned if Collect or Shutdown are called after a
 // reader has been Shutdown once.
-var ErrReaderShutdown = fmt.Errorf("reader is shutdown")
+var ErrReaderShutdown = errors.New("reader is shutdown")
 
 // errNonPositiveDuration is logged when an environmental variable
 // has non-positive value.
-var errNonPositiveDuration = fmt.Errorf("non-positive duration")
+var errNonPositiveDuration = errors.New("non-positive duration")
 
 // Reader is the interface used between the SDK and an
 // exporter.  Control flow is bi-directional through the
diff --git a/sdk/resource/builtin_test.go b/sdk/resource/builtin_test.go
@@ -5,7 +5,8 @@ package resource_test
 
 import (
 	"context"
-	"fmt"
+
+	"errors"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -15,7 +16,7 @@ import (
 )
 
 func TestBuiltinStringDetector(t *testing.T) {
-	E := fmt.Errorf("no K")
+	E := errors.New("no K")
 	res, err := resource.StringDetector("", attribute.Key("K"), func() (string, error) {
 		return "", E
 	}).Detect(context.Background())
@@ -33,7 +34,7 @@ func TestStringDetectorErrors(t *testing.T) {
 		{
 			desc: "explicit error from func should be returned",
 			s: resource.StringDetector("", attribute.Key("K"), func() (string, error) {
-				return "", fmt.Errorf("k-is-missing")
+				return "", errors.New("k-is-missing")
 			}),
 			errContains: "k-is-missing",
 		},
diff --git a/sdk/resource/resource_test.go b/sdk/resource/resource_test.go
@@ -9,6 +9,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"strconv"
 	"strings"
 	"sync"
 	"testing"
@@ -56,7 +57,7 @@ func TestNewWithAttributes(t *testing.T) {
 		},
 	}
 	for _, c := range cases {
-		t.Run(fmt.Sprintf("case-%s", c.name), func(t *testing.T) {
+		t.Run("case-"+c.name, func(t *testing.T) {
 			res := resource.NewSchemaless(c.in...)
 			if diff := cmp.Diff(
 				res.Attributes(),
@@ -177,7 +178,7 @@ func TestMerge(t *testing.T) {
 		},
 	}
 	for _, c := range cases {
-		t.Run(fmt.Sprintf("case-%s", c.name), func(t *testing.T) {
+		t.Run("case-"+c.name, func(t *testing.T) {
 			res, err := resource.Merge(c.a, c.b)
 			if c.isErr {
 				assert.Error(t, err)
@@ -560,7 +561,7 @@ func TestWithProcessPID(t *testing.T) {
 
 	require.NoError(t, err)
 	require.EqualValues(t, map[string]string{
-		"process.pid": fmt.Sprint(fakePID),
+		"process.pid": strconv.Itoa(fakePID),
 	}, toMap(res))
 }
 
@@ -674,7 +675,7 @@ func TestWithProcess(t *testing.T) {
 	require.NoError(t, err)
 	jsonCommandArgs, _ := json.Marshal(fakeCommandArgs)
 	require.EqualValues(t, map[string]string{
-		"process.pid":                 fmt.Sprint(fakePID),
+		"process.pid":                 strconv.Itoa(fakePID),
 		"process.executable.name":     fakeExecutableName,
 		"process.executable.path":     fakeExecutablePath,
 		"process.command_args":        string(jsonCommandArgs),
@@ -731,7 +732,7 @@ func TestWithContainerID(t *testing.T) {
 		{
 			name: "error",
 			containerIDProvider: func() (string, error) {
-				return "", fmt.Errorf("unable to get container id")
+				return "", errors.New("unable to get container id")
 			},
 			expectedResource: map[string]string{},
 			expectedErr:      true,
diff --git a/sdk/trace/sampler_env.go b/sdk/trace/sampler_env.go
@@ -5,7 +5,6 @@ package trace // import "go.opentelemetry.io/otel/sdk/trace"
 
 import (
 	"errors"
-	"fmt"
 	"os"
 	"strconv"
 	"strings"
@@ -26,7 +25,7 @@ const (
 type errUnsupportedSampler string
 
 func (e errUnsupportedSampler) Error() string {
-	return fmt.Sprintf("unsupported sampler: %s", string(e))
+	return "unsupported sampler: " + string(e)
 }
 
 var (
@@ -39,7 +38,7 @@ type samplerArgParseError struct {
 }
 
 func (e samplerArgParseError) Error() string {
-	return fmt.Sprintf("parsing sampler argument: %s", e.parseErr.Error())
+	return "parsing sampler argument: " + e.parseErr.Error()
 }
 
 func (e samplerArgParseError) Unwrap() error {

Original file line number	Diff line number	Diff line change
`@@ -128,5 +128,5 @@ func (s *Span) AddLink(l octrace.Link) {`
`128`	`128`
`129`	`129`	`// String prints a string representation of this span.`
`130`	`130`	`func (s *Span) String() string {`
`131`		`- return fmt.Sprintf("span %s", s.otelSpan.SpanContext().SpanID().String())`
	`131`	`+ return "span " + s.otelSpan.SpanContext().SpanID().String()`
`132`	`132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ package codes // import "go.opentelemetry.io/otel/codes"`
`5`	`5`
`6`	`6`	`import (`
`7`	`7`	`"encoding/json"`
	`8`	`+ "errors"`
`8`	`9`	`"fmt"`
`9`	`10`	`"strconv"`
`10`	`11`	`)`
`@@ -63,7 +64,7 @@ func (c *Code) UnmarshalJSON(b []byte) error {`
`63`	`64`	`return nil`
`64`	`65`	`}`
`65`	`66`	`if c == nil {`
`66`		`- return fmt.Errorf("nil receiver passed to UnmarshalJSON")`
	`67`	`+ return errors.New("nil receiver passed to UnmarshalJSON")`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`var x interface{}`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ func cleanPath(urlPath string, defaultPath string) string {`
`111`	`111`	`return defaultPath`
`112`	`112`	`}`
`113`	`113`	`if !path.IsAbs(tmp) {`
`114`		`- tmp = fmt.Sprintf("/%s", tmp)`
	`114`	`+ tmp = "/" + tmp`
`115`	`115`	`}`
`116`	`116`	`return tmp`
`117`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ func newResponseError(header http.Header, wrapped error) error {`
`305`	`305`
`306`	`306`	`func (e retryableError) Error() string {`
`307`	`307`	`if e.err != nil {`
`308`		`- return fmt.Sprintf("retry-able request failure: %s", e.err.Error())`
	`308`	`+ return "retry-able request failure: " + e.err.Error()`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`return "retry-able request failure"`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ func cleanPath(urlPath string, defaultPath string) string {`
`98`	`98`	`return defaultPath`
`99`	`99`	`}`
`100`	`100`	`if !path.IsAbs(tmp) {`
`101`		`- tmp = fmt.Sprintf("/%s", tmp)`
	`101`	`+ tmp = "/" + tmp`
`102`	`102`	`}`
`103`	`103`	`return tmp`
`104`	`104`	`}`
Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,7 @@ func newResponseError(header http.Header, wrapped error) error {`
`327`	`327`
`328`	`328`	`func (e retryableError) Error() string {`
`329`	`329`	`if e.err != nil {`
`330`		`- return fmt.Sprintf("retry-able request failure: %s", e.err.Error())`
	`330`	`+ return "retry-able request failure: " + e.err.Error()`
`331`	`331`	`}`
`332`	`332`
`333`	`333`	`return "retry-able request failure"`