fix: Immutability of context #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
immutable-context
branch
from
85c489a to
8e5a1f8
Compare
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
immutable-context
branch
from
2ac57f7 to
432f224
Compare
nicklasl
reviewed
Jul 28, 2025
nicklasl
reviewed
Jul 28, 2025
nicklasl
approved these changes
Jul 28, 2025
beeme1mr
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ImmutableContext class was accepting mutable maps in its constructor, allowing callers to modify the original map after instantiation, which would affect the "immutable" context. This violated the immutability guarantee and could lead to unexpected behavior.
Solution
Implemented comprehensive deep immutability through defensive copying at all levels
Related Issues
Fixes #150
Notes
This change is backwards compatible at the API level. However if an integration was performing collection mutation for collections used in a context object, the behavior might now change.