refactor!: rework states and adapt spec v0.8 #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fabriziodemaria
left a comment
fabriziodemaria
left a comment
There was a problem hiding this comment.
Looks good! Let's just make sure to align on the main APIs together with the Swift counterpart before shipping
nicklasl
force-pushed
the
rework-states
branch
2 times, most recently
from
e80c6dc to
75b793e
Compare
Member
Author
|
Notes:
|
nicklasl
force-pushed
the
rework-states
branch
2 times, most recently
from
d1bd76d to
4eb640b
Compare
Signed-off-by: Nicklas Lundin <[email protected]> Signed-off-by: Nicklas Lundin <[email protected]> fix: mark as throws Signed-off-by: Nicklas Lundin <[email protected]> Signed-off-by: Nicklas Lundin <[email protected]> Signed-off-by: Nicklas Lundin <[email protected]> Signed-off-by: Nicklas Lundin <[email protected]> fix: add extra buffer capacity for the status flow Signed-off-by: Nicklas Lundin <[email protected]> fix: short circuit on fatal/non ready status refactor!: align setProvider API naming with Swift SDK Signed-off-by: Nicklas Lundin <[email protected]>
Signed-off-by: Nicklas Lundin <[email protected]>
Signed-off-by: Nicklas Lundin <[email protected]>
nicklasl
force-pushed
the
rework-states
branch
from
80173dc to
3c29502
Compare
Member
Author
|
Unfortunately at the current state, the Eventing aspect was removed from the SDK. |
nickybondarenko
approved these changes
Feb 5, 2025
Contributor
nickybondarenko
left a comment
nickybondarenko
left a comment
There was a problem hiding this comment.
Really appreciate the documentation! Great work!
beeme1mr
approved these changes
Feb 6, 2025
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Will events be re-added before releasing the update?
Signed-off-by: Nicklas Lundin <[email protected]>
nicklasl
force-pushed
the
rework-states
branch
from
3de7f2c to
abb3451
Compare
Member
Author
Yeah, that's my plan. |
fabriziodemaria
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning with Spec 0.8.0
This PR
Moves all status handling to the SDK and relies on how the Provider respond to different API calls to expose the correct status.
There are multiple breaking changes in this PR since there are multiple places where the Provider APIs are changed to be suspending functions and the provider is also expected to throw exceptions in the case of failures.
There are big wins for the Provider authors here since there is no need for the provider to emit the statuses using the EventHandler, thus this class is removed.
Aligns with open-feature/swift-sdk#46
Notes on Breaking changes
Provider author breakage
initializeandonContextSetare now suspending and are expecting to throw exceptions on errors.observe()in favour of event handling via SDK calls.SDK consumer breakage
FeatureProvider.awaitReadyOrError()extension function