fix

Author: recca0120

src/Message/MyCash/CompletePurchaseRequest.php

@@ -2,7 +2,7 @@
 
 namespace Omnipay\EPays\Message\MyCash;
 
-use Omnipay\Common\Exception\InvalidResponseException;
+use Omnipay\Common\Exception\InvalidRequestException;
 use Omnipay\Common\Message\AbstractRequest;
 use Omnipay\EPays\Traits\MyCash\HasMyCash;
 
@@ -13,15 +13,13 @@ class CompletePurchaseRequest extends AbstractRequest
     /**
      * @return array
      *
-     * @throws InvalidResponseException
+     * @throws InvalidRequestException
      */
     public function getData()
     {
         $data = $this->httpRequest->request->all();
-        $validate = array_key_exists('Validate', $data) ? $data['Validate'] : '';
-
-        if ($this->makeHash($data) !== $validate) {
-            throw new InvalidResponseException('Incorrect hash');
+        if (! hash_equals($this->makeHash($data), $this->httpRequest->request->get('Validate'))) {
+            throw new InvalidRequestException('Incorrect hash');
         }
 
         return $data;

src/Message/MyCash/GetPaymentInfoRequest.php

@@ -18,8 +18,7 @@ class GetPaymentInfoRequest extends AbstractRequest
     public function getData()
     {
         $data = $this->httpRequest->request->all();
-
-        if (! hash_equals($this->httpRequest->request->get('Validate'), $this->makeHash($data))) {
+        if (! hash_equals($this->makeHash($data), $this->httpRequest->request->get('Validate'))) {
             throw new InvalidResponseException('Incorrect hash');
         }
 

tests/Message/MyCash/AcceptNotificationRequestTest.php

@@ -2,7 +2,7 @@
 
 namespace Omnipay\EPays\Tests\Message\MyCash;
 
-use Omnipay\Common\Exception\InvalidResponseException;
+use Omnipay\Common\Exception\InvalidRequestException;
 use Omnipay\Common\Message\NotificationInterface;
 use Omnipay\EPays\Message\MyCash\AcceptNotificationRequest;
 use Omnipay\EPays\Message\MyCash\CompletePurchaseRequest;
@@ -18,7 +18,7 @@ class AcceptNotificationRequestTest extends TestCase
 
     public function testValidateFails(): void
     {
-        $this->expectException(InvalidResponseException::class);
+        $this->expectException(InvalidRequestException::class);
 
         $options = [
             'RtnCode' => '1',

tests/Message/MyCash/CompletePurchaseRequestTest.php

@@ -2,7 +2,7 @@
 
 namespace Omnipay\EPays\Tests\Message\MyCash;
 
-use Omnipay\Common\Exception\InvalidResponseException;
+use Omnipay\Common\Exception\InvalidRequestException;
 use Omnipay\EPays\Message\MyCash\CompletePurchaseRequest;
 use Omnipay\Tests\TestCase;
 
@@ -16,7 +16,7 @@ class CompletePurchaseRequestTest extends TestCase
 
     public function testValidateFails(): void
     {
-        $this->expectException(InvalidResponseException::class);
+        $this->expectException(InvalidRequestException::class);
         $this->expectExceptionMessage('Incorrect hash');
 
         $options = [