Skip to content

Commit 92963e1

Browse files
committed
1 parent 9b190b2 commit 92963e1

File tree

1 file changed

+31
-17
lines changed

1 file changed

+31
-17
lines changed

test/plugin.test.ts

Lines changed: 31 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -232,34 +232,48 @@ describe("Github API best practices", function () {
232232
},
233233
});
234234

235-
const req1 = octokit.request("GET /search/route1", {
235+
const req1 = octokit.request("GET /search/route", {
236236
request: {
237-
responses: [{ status: 201, headers: {}, data: {} }],
238-
},
239-
});
240-
const req2 = octokit.request("GET /route2", {
241-
request: {
242-
responses: [{ status: 202, headers: {}, data: {} }],
237+
responses: [{ status: 200, headers: {}, data: {} }],
243238
},
244239
});
245-
const req3 = octokit.request("GET /search/route3", {
240+
const req2 = octokit.request("GET /other-route", {
246241
request: {
247-
responses: [{ status: 203, headers: {}, data: {} }],
242+
responses: [{ status: 200, headers: {}, data: {} }],
248243
},
249244
});
245+
const req3 = octokit.request(
246+
"GET https://api.github.com/search/route?page=2",
247+
{
248+
request: {
249+
responses: [{ status: 200, headers: {}, data: {} }],
250+
},
251+
}
252+
);
253+
const req4 = octokit.request(
254+
"GET https://api.github.com/search/route?page=3",
255+
{
256+
request: {
257+
responses: [{ status: 200, headers: {}, data: {} }],
258+
},
259+
}
260+
);
250261

251-
await Promise.all([req1, req2, req3]);
262+
await Promise.all([req1, req2, req3, req4]);
252263
expect(octokit.__requestLog).toStrictEqual([
253-
"START GET /route2",
254-
"END GET /route2",
255-
"START GET /search/route1",
256-
"END GET /search/route1",
257-
"START GET /search/route3",
258-
"END GET /search/route3",
264+
"START GET /other-route",
265+
"END GET /other-route",
266+
"START GET /search/route",
267+
"END GET /search/route",
268+
"START GET https://api.github.com/search/route?page=2",
269+
"END GET https://api.github.com/search/route?page=2",
270+
"START GET https://api.github.com/search/route?page=3",
271+
"END GET https://api.github.com/search/route?page=3",
259272
]);
273+
260274
expect(
261275
octokit.__requestTimings[4] - octokit.__requestTimings[2]
262-
).toBeLessThan(70);
276+
).toBeGreaterThanOrEqual(50);
263277
});
264278

265279
it("Should optimize throughput rather than maintain ordering", async function () {

0 commit comments

Comments
 (0)