Skip to content

Conversation

@wolfy1339
Copy link
Member

See octokit/octokit.js#2762 (comment)

Resolves #ISSUE_NUMBER


Before the change?

  • Types would include a reference to @types/node even though there is nothing using Node specific APIs in the types

After the change?

  • Update @octokit/types to make sure types are platform agnostic

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Bump dependencies to avoid bugs with Deno compatibility
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Dec 29, 2024
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 requested a review from oscard0m December 31, 2024 15:35
@wolfy1339 wolfy1339 merged commit 9fa91ea into main Dec 31, 2024
7 checks passed
@wolfy1339 wolfy1339 deleted the octokit-deps branch December 31, 2024 16:17
@github-actions
Copy link

🎉 This issue has been resolved in version 5.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants