Skip to content

Conversation

@Barbapapazes
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hello πŸ‘‹,

Following #4350, it makes sense to remove the default size on the close button of the slideover and the modal components as it will override the default variant size.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 16, 2025

npm i https://pkg.pr.new/@nuxt/ui@4357

commit: 5c07f71

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few components that have size="md" like Alert, Carousel, CommandPalette, etc. Should we remove it everywhere? πŸ€”

I can't remember why I put those initially and hope it will not break anything 😬

@Barbapapazes

This comment was marked as outdated.

@Barbapapazes Barbapapazes marked this pull request as draft June 17, 2025 17:13
@Barbapapazes Barbapapazes changed the title fix(Slideover,Modal): remove default close button size fix(Slideover,Modal,Alert,Toast,Carousel,CommandPalette): remove default close button size Jun 17, 2025
@Barbapapazes
Copy link
Contributor Author

There are quite a few components that have size="md" like Alert, Carousel, CommandPalette, etc. Should we remove it everywhere? πŸ€”

I can't remember why I put those initially and hope it will not break anything 😬

I changed all components impacted. I verify that removing the default size does not change anything. But now, by simply changing the defaultVariants.size to sm change every components.

@Barbapapazes Barbapapazes marked this pull request as ready for review June 17, 2025 17:26
@Barbapapazes Barbapapazes force-pushed the fix/slideover-close-button branch from f046652 to e8e5a9f Compare June 17, 2025 17:26
@benjamincanac benjamincanac changed the title fix(Slideover,Modal,Alert,Toast,Carousel,CommandPalette): remove default close button size fix(components): remove default md size on buttons Jun 23, 2025
@benjamincanac benjamincanac merged commit be41aed into nuxt:v3 Jun 23, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 #1289

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants