Skip to content

fix(Carousel/Tree): add type to button elements for accessibility #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix(Carousel/Tree): add type to button elements for accessibility #4493

merged 1 commit into from
Jul 9, 2025

Conversation

@hywax
Copy link
Member

@hywax hywax commented Jul 9, 2025

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

If components are used inside a form, the sumbit is triggered. This should not happen

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@hywax hywax requested a review from benjamincanac as a code owner July 9, 2025 15:10
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 9, 2025 

npm i https://pkg.pr.new/@nuxt/ui@4493

commit: 88eda5f

@benjamincanac benjamincanac merged commit c47d26f into nuxt:v3 Jul 9, 2025
6 checks passed
benjamincanac pushed a commit that referenced this pull request Jul 9, 2025
@hywax @benjamincanac
fix(Carousel/Tree): add type to button elements for accessibility (#4493
fc24e03 
)
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hywax @benjamincanac