fix(NavigationMenu): arrow position conflict #4137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #4073
β Type of change
π Description
The main issue lies in
NavigationMenuspecifically in how the defaultvalueis set when renderingNavigationMenuItem.In reka-ui, the library uses the default item value as reference to find the active element:
However, this can lead to incorrect matches due to the way IDs are generated. If we inspect the ID generation logic the ID often includes an index, for example:
reka-navigation-menu-v-10-trigger-0In this case, if we hover the second tab,
modelValue.valuewill be equal to1. The includes check will mistakenly match this ID (because1is included in10), returning the wrong element, typically the first item instead of the second here.This issue becomes more likely when item values are simple strings like numeric indices ("0", "1", etc.). A more robust comparison would avoid this kind of false-positive match.
π Checklist