Skip to content

Commit fbe355c

Browse files
lukekarryslukekarrys
authored
fix: pin release-please version (#388)
- fix: pin release-please version There is a tradeoff with our usage of release-please. We are using some `release-please` classes that we import directly from files like `const { ManifestPlugin } = require('release-please/build/src/plugin.js')`. Due to how load bearing our release process is for us, I think it is best to always pin to an exact version and use dependabot PRs to review all `release-please` changes. - chore: update release please mocks and snapshots This PR also updates mocks and snapshots. I was not expecting this to need to be updated but they failed in #385. It's possible that the mock recording or the usage of these mocks inside release-please is non-deterministic. I will keep an eye on these tests and refactor in the future if they turn out to be flaky.
1 parent 4fad5d8 commit fbe355c

9 files changed

+328
-469
lines changed

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ The files `test/release/release-manager.js` and `test/release/release-please.js`
130130
use recorded `nock` fixtures to generate snapshots. To update these fixtures run:
131131

132132
```sh
133-
GITHUB_TOKEN=<YOUR_PAT> npm run test:record --- test/release/release-{please,manager}.js
133+
GITHUB_TOKEN=$(gh auth token) npm run test:record --- test/release/release-{please,manager}.js
134134
```
135135

136136
If you only need to update fixtures for one, it's best to only run that single

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"minimatch": "^9.0.2",
5757
"npm-package-arg": "^11.0.1",
5858
"proc-log": "^3.0.0",
59-
"release-please": "^16.3.1",
59+
"release-please": "16.3.1",
6060
"semver": "^7.3.5",
6161
"undici": "^5.27.2",
6262
"yaml": "^2.1.1"

‎tap-snapshots/test/release/release-please-cases-fix-all.js.test.cjs‎

Lines changed: 129 additions & 271 deletions
Large diffs are not rendered by default.

‎tap-snapshots/test/release/release-please-cases-fix-one.js.test.cjs‎

Lines changed: 71 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -13,45 +13,45 @@ Object {
1313
---
1414
1515
16-
<details><summary>2012.0.4</summary>
16+
<details><summary>2013.0.2-pre</summary>
1717
18-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/v2012.0.3...v2012.0.4) (2023-11-28)
18+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2013.0.1-pre...v2013.0.2-pre) (2023-12-01)
1919
2020
### Bug Fixes
2121
22-
* [\`0a2bf35\`](https://github.com/npm/npm-cli-release-please/commit/0a2bf35304e69331138d4981bd7ecc75d86e83de) update pkg3 (@lukekarrys)
22+
* [\`99ddeec\`](https://github.com/npm/npm-cli-release-please/commit/99ddeecd1d548f17901e6547d12921b829d4b509) update pkg3 (@lukekarrys)
2323
2424
### Dependencies
2525
26-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2012.0.4): \`pkg1@2012.0.4\`
27-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2012.0.4): \`pkg2@2012.0.4\`
26+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2013.0.2-pre): \`pkg1@2013.0.2-pre\`
27+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2013.0.2-pre): \`pkg2@2013.0.2-pre\`
2828
</details>
2929
30-
<details><summary>pkg1: 2012.0.4</summary>
30+
<details><summary>pkg1: 2013.0.2-pre</summary>
3131
32-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2012.0.3...pkg1-v2012.0.4) (2023-11-28)
32+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2013.0.1-pre...pkg1-v2013.0.2-pre) (2023-12-01)
3333
3434
### Dependencies
3535
36-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2012.0.4): \`pkg2@2012.0.4\`
36+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2013.0.2-pre): \`pkg2@2013.0.2-pre\`
3737
</details>
3838
39-
<details><summary>pkg2: 2012.0.4</summary>
39+
<details><summary>pkg2: 2013.0.2-pre</summary>
4040
41-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2012.0.3...pkg2-v2012.0.4) (2023-11-28)
41+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2013.0.1-pre...pkg2-v2013.0.2-pre) (2023-12-01)
4242
4343
### Dependencies
4444
45-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2012.0.4): \`@npmcli/pkg3@2012.0.4\`
45+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2013.0.2-pre): \`@npmcli/pkg3@2013.0.2-pre\`
4646
</details>
4747
48-
<details><summary>pkg3: 2012.0.4</summary>
48+
<details><summary>pkg3: 2013.0.2-pre</summary>
4949
50-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2012.0.3...pkg3-v2012.0.4) (2023-11-28)
50+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2013.0.1-pre...pkg3-v2013.0.2-pre) (2023-12-01)
5151
5252
### Bug Fixes
5353
54-
* [\`0a2bf35\`](https://github.com/npm/npm-cli-release-please/commit/0a2bf35304e69331138d4981bd7ecc75d86e83de) update pkg3 (@lukekarrys)
54+
* [\`99ddeec\`](https://github.com/npm/npm-cli-release-please/commit/99ddeecd1d548f17901e6547d12921b829d4b509) update pkg3 (@lukekarrys)
5555
</details>
5656
5757
---
@@ -62,114 +62,114 @@ Object {
6262
"labels": Array [
6363
"autorelease: pending",
6464
],
65-
"number": 251,
66-
"sha": "2523cec182cd2199f1c41d818c69bdc07a74f80f",
67-
"title": "chore: release 2012.0.4",
65+
"number": 254,
66+
"sha": "18a19f22fceb96272b592a8c4f8144bb890fe084",
67+
"title": "chore: release 2013.0.2-pre",
6868
}
6969
`
7070

7171
exports[`test/release/release-please.js TAP cases fix one > releases update pkg3 1`] = `
7272
Array [
7373
Object {
7474
"draft": false,
75-
"id": 131773216,
76-
"major": 2012,
75+
"id": 132321884,
76+
"major": 2013,
7777
"minor": 0,
78-
"name": "v2012.0.4",
78+
"name": "v2013.0.2-pre",
7979
"notes": String(
80-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/v2012.0.3...v2012.0.4) (2023-11-28)
80+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2013.0.1-pre...v2013.0.2-pre) (2023-12-01)
8181
8282
### Bug Fixes
8383
84-
* [\`0a2bf35\`](https://github.com/npm/npm-cli-release-please/commit/0a2bf35304e69331138d4981bd7ecc75d86e83de) update pkg3 (@lukekarrys)
84+
* [\`99ddeec\`](https://github.com/npm/npm-cli-release-please/commit/99ddeecd1d548f17901e6547d12921b829d4b509) update pkg3 (@lukekarrys)
8585
8686
### Dependencies
8787
88-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2012.0.4): \`pkg1@2012.0.4\`
89-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2012.0.4): \`pkg2@2012.0.4\`
88+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2013.0.2-pre): \`pkg1@2013.0.2-pre\`
89+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2013.0.2-pre): \`pkg2@2013.0.2-pre\`
9090
),
91-
"patch": 4,
91+
"patch": 2,
9292
"path": ".",
9393
"pkgName": "npm-cli-release-please",
94-
"prNumber": 251,
95-
"publishTag": "latest",
96-
"sha": "731c147ec26b668c8fc52d346ded534d6cde1241",
97-
"tagName": "v2012.0.4",
98-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/131773216/assets{?name,label}",
99-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2012.0.4",
100-
"version": "2012.0.4",
94+
"prNumber": 254,
95+
"publishTag": "prerelease-2013",
96+
"sha": "6a8a6ff465fc9ac43e8e0860247fd0daf5ac3edf",
97+
"tagName": "v2013.0.2-pre",
98+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132321884/assets{?name,label}",
99+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2013.0.2-pre",
100+
"version": "2013.0.2-pre",
101101
},
102102
Object {
103103
"draft": false,
104-
"id": 131773219,
105-
"major": 2012,
104+
"id": 132321886,
105+
"major": 2013,
106106
"minor": 0,
107-
"name": "pkg1: v2012.0.4",
107+
"name": "pkg1: v2013.0.2-pre",
108108
"notes": String(
109-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2012.0.3...pkg1-v2012.0.4) (2023-11-28)
109+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2013.0.1-pre...pkg1-v2013.0.2-pre) (2023-12-01)
110110
111111
### Dependencies
112112
113-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2012.0.4): \`pkg2@2012.0.4\`
113+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2013.0.2-pre): \`pkg2@2013.0.2-pre\`
114114
),
115-
"patch": 4,
115+
"patch": 2,
116116
"path": "pkg1",
117117
"pkgName": "pkg1",
118-
"prNumber": 251,
119-
"publishTag": "latest",
120-
"sha": "731c147ec26b668c8fc52d346ded534d6cde1241",
121-
"tagName": "pkg1-v2012.0.4",
122-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/131773219/assets{?name,label}",
123-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2012.0.4",
124-
"version": "2012.0.4",
118+
"prNumber": 254,
119+
"publishTag": "prerelease-2013",
120+
"sha": "6a8a6ff465fc9ac43e8e0860247fd0daf5ac3edf",
121+
"tagName": "pkg1-v2013.0.2-pre",
122+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132321886/assets{?name,label}",
123+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2013.0.2-pre",
124+
"version": "2013.0.2-pre",
125125
},
126126
Object {
127127
"draft": false,
128-
"id": 131773224,
129-
"major": 2012,
128+
"id": 132321889,
129+
"major": 2013,
130130
"minor": 0,
131-
"name": "pkg2: v2012.0.4",
131+
"name": "pkg2: v2013.0.2-pre",
132132
"notes": String(
133-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2012.0.3...pkg2-v2012.0.4) (2023-11-28)
133+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2013.0.1-pre...pkg2-v2013.0.2-pre) (2023-12-01)
134134
135135
### Dependencies
136136
137-
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2012.0.4): \`@npmcli/pkg3@2012.0.4\`
137+
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2013.0.2-pre): \`@npmcli/pkg3@2013.0.2-pre\`
138138
),
139-
"patch": 4,
139+
"patch": 2,
140140
"path": "pkg2",
141141
"pkgName": "pkg2",
142-
"prNumber": 251,
143-
"publishTag": "latest",
144-
"sha": "731c147ec26b668c8fc52d346ded534d6cde1241",
145-
"tagName": "pkg2-v2012.0.4",
146-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/131773224/assets{?name,label}",
147-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2012.0.4",
148-
"version": "2012.0.4",
142+
"prNumber": 254,
143+
"publishTag": "prerelease-2013",
144+
"sha": "6a8a6ff465fc9ac43e8e0860247fd0daf5ac3edf",
145+
"tagName": "pkg2-v2013.0.2-pre",
146+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132321889/assets{?name,label}",
147+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2013.0.2-pre",
148+
"version": "2013.0.2-pre",
149149
},
150150
Object {
151151
"draft": false,
152-
"id": 131773227,
153-
"major": 2012,
152+
"id": 132321890,
153+
"major": 2013,
154154
"minor": 0,
155-
"name": "pkg3: v2012.0.4",
155+
"name": "pkg3: v2013.0.2-pre",
156156
"notes": String(
157-
## [2012.0.4](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2012.0.3...pkg3-v2012.0.4) (2023-11-28)
157+
## [2013.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2013.0.1-pre...pkg3-v2013.0.2-pre) (2023-12-01)
158158
159159
### Bug Fixes
160160
161-
* [\`0a2bf35\`](https://github.com/npm/npm-cli-release-please/commit/0a2bf35304e69331138d4981bd7ecc75d86e83de) update pkg3 (@lukekarrys)
161+
* [\`99ddeec\`](https://github.com/npm/npm-cli-release-please/commit/99ddeecd1d548f17901e6547d12921b829d4b509) update pkg3 (@lukekarrys)
162162
),
163-
"patch": 4,
163+
"patch": 2,
164164
"path": "pkg3",
165165
"pkgName": "@npmcli/pkg3",
166-
"prNumber": 251,
167-
"publishTag": "latest",
168-
"sha": "731c147ec26b668c8fc52d346ded534d6cde1241",
169-
"tagName": "pkg3-v2012.0.4",
170-
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/131773227/assets{?name,label}",
171-
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2012.0.4",
172-
"version": "2012.0.4",
166+
"prNumber": 254,
167+
"publishTag": "prerelease-2013",
168+
"sha": "6a8a6ff465fc9ac43e8e0860247fd0daf5ac3edf",
169+
"tagName": "pkg3-v2013.0.2-pre",
170+
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132321890/assets{?name,label}",
171+
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2013.0.2-pre",
172+
"version": "2013.0.2-pre",
173173
},
174174
]
175175
`

0 commit comments

Comments
 (0)