fix: remove custom node-workspace plugin

release-please now has all the fixes we need and we can
use the upstream plugin

Author: lukekarrys

lib/release/node-workspace-format.js

@@ -11,7 +11,6 @@ module.exports = class extends ManifestPlugin {
 
   #releasesByPackage = new Map()
   #pathsByComponent = new Map()
-  #WORKSPACE_SCOPE = /(?<scope>workspace): `?(?<name>\S+?)[@\s](?<version>\S+?)`?$/gm
 
   async preconfigure (strategiesByPath) {
     // First build a list of all releases that will happen based on
@@ -32,6 +31,16 @@ module.exports = class extends ManifestPlugin {
     return candidates
   }
 
+  #replaceWorkspace ({ name, versionRange }) {
+    const version = versionRange.replace(/^[\^~]/, '')
+    const { path, component } = this.#releasesByPackage.get(name)
+    const { tagSeparator, includeVInTag } = this.repositoryConfig[path]
+    const { repository: { owner, repo } } = this.github
+    const tag = new TagName(version, component, tagSeparator, includeVInTag).toString()
+    const url = `https://github.com/${owner}/${repo}/releases/tag/${tag}`
+    return `${link('workspace', url)}: ${wrapSpecs(`${name}@${version}`)}`
+  }
+
   // I don't like how release-please formats workspace changelog entries
   // so this rewrites them to look like the rest of our changelog. This can't
   // be part of the changelog plugin since they are written after that by the
@@ -42,16 +51,20 @@ module.exports = class extends ManifestPlugin {
       for (const release of candidate.pullRequest.body.releaseData) {
         // Update notes with a link to each workspaces release notes
         // now that we have all of the releases in a single pull request
-        release.notes =
-          release.notes.replace(this.#WORKSPACE_SCOPE, (...args) => {
-            const { scope, name, version } = args.pop()
-            const { path, component } = this.#releasesByPackage.get(name)
-            const { tagSeparator, includeVInTag } = this.repositoryConfig[path]
-            const { repository: { owner, repo } } = this.github
-            const tag = new TagName(version, component, tagSeparator, includeVInTag).toString()
-            const url = `https://github.com/${owner}/${repo}/releases/tag/${tag}`
-            return `${link(scope, url)}: ${wrapSpecs(`${name}@${version}`)}`
-          })
+        release.notes = release.notes
+          .replace(/^\* The following workspace dependencies were updated\n/gm, '')
+          .replace(/^\s{2}\* dependencies\n/gm, '')
+          .replace(/^\s{2}\* devDependencies\n/gm, '')
+          .replace(/^\s{2}\* peerDependencies\n/gm, '')
+          .replace(/^\s{2}\* optionalDependencies\n/gm, '')
+          .replace(
+            /^\s{4}\* (?<name>[^\s]+) bumped to (?<versionRange>[^\s]+)/gm,
+            (...args) => this.#replaceWorkspace(args.at(-1))
+          )
+          .replace(
+            /^\s{4}\* (?<name>[^\s]+) bumped from (?:[^\s]+) to (?<versionRange>[^\s]+)/gm,
+            (...args) => this.#replaceWorkspace(args.at(-1))
+          )
 
         // Find the associated changelog and update that too
         const path = this.#pathsByComponent.get(release.component)

lib/release/node-workspace.js

@@ -11,7 +11,6 @@ const assert = require('assert')
 const core = require('@actions/core')
 const omit = require('just-omit')
 const ChangelogNotes = require('./changelog.js')
-const NodeWorkspace = require('./node-workspace.js')
 const NodeWorkspaceFormat = require('./node-workspace-format.js')
 const { getPublishTag, noop } = require('./util.js')
 
@@ -69,8 +68,6 @@ class ReleasePlease {
       new ChangelogNotes(github, o))
     RP.registerVersioningStrategy('default', (o) =>
       o.prerelease ? new PrereleaseVersioningStrategy(o) : new DefaultVersioningStrategy(o))
-    RP.registerPlugin('node-workspace', ({ github, targetBranch, repositoryConfig, ...o }) =>
-      new NodeWorkspace(github, targetBranch, repositoryConfig, o))
     RP.registerPlugin('node-workspace-format', ({ github, targetBranch, repositoryConfig, ...o }) =>
       new NodeWorkspaceFormat(github, targetBranch, repositoryConfig, o))