deps: @npmcli/[email protected]

Author: lukekarrys

DEPENDENCIES.md

@@ -228,6 +228,7 @@ graph LR;
   npmcli-run-script-->npmcli-node-gyp["@npmcli/node-gyp"];
   npmcli-run-script-->npmcli-package-json["@npmcli/package-json"];
   npmcli-run-script-->npmcli-promise-spawn["@npmcli/promise-spawn"];
+  npmcli-run-script-->proc-log;
   npmcli-smoke-tests-->npmcli-eslint-config["@npmcli/eslint-config"];
   npmcli-smoke-tests-->npmcli-mock-registry["@npmcli/mock-registry"];
   npmcli-smoke-tests-->npmcli-promise-spawn["@npmcli/promise-spawn"];
@@ -700,6 +701,7 @@ graph LR;
   npmcli-run-script-->npmcli-node-gyp["@npmcli/node-gyp"];
   npmcli-run-script-->npmcli-package-json["@npmcli/package-json"];
   npmcli-run-script-->npmcli-promise-spawn["@npmcli/promise-spawn"];
+  npmcli-run-script-->proc-log;
   npmcli-run-script-->which;
   npmcli-smoke-tests-->npmcli-eslint-config["@npmcli/eslint-config"];
   npmcli-smoke-tests-->npmcli-mock-registry["@npmcli/mock-registry"];

lib/commands/ci.js

@@ -109,7 +109,6 @@ class CI extends ArboristWorkspaceCmd {
           args: [],
           scriptShell,
           stdio: 'inherit',
-          banner: !this.npm.silent,
           event,
         })
       }

lib/commands/explore.js

@@ -56,7 +56,6 @@ class Explore extends BaseCommand {
     return runScript({
       ...this.npm.flatOptions,
       pkg,
-      banner: false,
       path,
       event: '_explore',
       stdio: 'inherit',

lib/commands/install.js

@@ -168,7 +168,6 @@ class Install extends ArboristWorkspaceCmd {
           args: [],
           scriptShell,
           stdio: 'inherit',
-          banner: !this.npm.silent,
           event,
         })
       }

lib/commands/publish.js

@@ -72,7 +72,6 @@ class Publish extends BaseCommand {
         path: spec.fetchSpec,
         stdio: 'inherit',
         pkg: manifest,
-        banner: !silent,
       })
     }
 
@@ -131,15 +130,13 @@ class Publish extends BaseCommand {
         path: spec.fetchSpec,
         stdio: 'inherit',
         pkg: manifest,
-        banner: !silent,
       })
 
       await runScript({
         event: 'postpublish',
         path: spec.fetchSpec,
         stdio: 'inherit',
         pkg: manifest,
-        banner: !silent,
       })
     }
 

lib/commands/run-script.js

@@ -114,7 +114,6 @@ class RunScript extends BaseCommand {
         scriptShell,
         stdio: 'inherit',
         pkg,
-        banner: !this.npm.silent,
         event: ev,
         args: evArgs,
       })

node_modules/.gitignore

@@ -181,11 +181,6 @@
 !/npm-user-validate
 !/p-map
 !/pacote
-!/pacote/node_modules/
-/pacote/node_modules/*
-!/pacote/node_modules/@npmcli/
-/pacote/node_modules/@npmcli/*
-!/pacote/node_modules/@npmcli/run-script
 !/parse-conflict-json
 !/path-key
 !/path-scurry

node_modules/@npmcli/run-script/lib/run-script-pkg.js

@@ -5,19 +5,6 @@ const { isNodeGypPackage, defaultGypInstallScript } = require('@npmcli/node-gyp'
 const signalManager = require('./signal-manager.js')
 const isServerPackage = require('./is-server-package.js')
 
-// you wouldn't like me when I'm angry...
-const bruce = (id, event, cmd, args) => {
-  let banner = id
-    ? `\n> ${id} ${event}\n`
-    : `\n> ${event}\n`
-  banner += `> ${cmd.trim().replace(/\n/g, '\n> ')}`
-  if (args.length) {
-    banner += ` ${args.join(' ')}`
-  }
-  banner += '\n'
-  return banner
-}
-
 const runScriptPkg = async options => {
   const {
     event,
@@ -29,8 +16,6 @@ const runScriptPkg = async options => {
     pkg,
     args = [],
     stdioString,
-    // note: only used when stdio:inherit
-    banner = true,
     // how long to wait for a process.kill signal
     // only exposed here so that we can make the test go a bit faster.
     signalTimeout = 500,
@@ -59,9 +44,20 @@ const runScriptPkg = async options => {
     return { code: 0, signal: null }
   }
 
-  if (stdio === 'inherit' && banner !== false) {
-    // we're dumping to the parent's stdout, so print the banner
-    console.log(bruce(pkg._id, event, cmd, args))
+  if (stdio === 'inherit') {
+    let banner
+    if (pkg._id) {
+      banner = `\n> ${pkg._id} ${event}\n`
+    } else {
+      banner = `\n> ${event}\n`
+    }
+    banner += `> ${cmd.trim().replace(/\n/g, '\n> ')}`
+    if (args.length) {
+      banner += ` ${args.join(' ')}`
+    }
+    banner += '\n'
+    const { output } = require('proc-log')
+    output.standard(banner)
   }
 
   const [spawnShell, spawnArgs, spawnOpts] = makeSpawnArgs({

node_modules/@npmcli/run-script/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@npmcli/run-script",
-  "version": "7.0.4",
+  "version": "8.0.0",
   "description": "Run a lifecycle script for a package (descendant of npm-lifecycle)",
   "author": "GitHub Inc.",
   "license": "ISC",
@@ -25,6 +25,7 @@
     "@npmcli/package-json": "^5.0.0",
     "@npmcli/promise-spawn": "^7.0.0",
     "node-gyp": "^10.0.0",
+    "proc-log": "^4.0.0",
     "which": "^4.0.0"
   },
   "files": [