ci: fix node24 ci, update crypto keys because of openSSL 3.5.1 upgrade in nodejs 24.5.0 #4400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
force-pushed
the
fix-node24-ci
branch
2 times, most recently
from
0927526 to
a1dacb1
Compare
Uzlopak
changed the title
gurgunday
approved these changes
Aug 9, 2025
himself65
approved these changes
Aug 9, 2025
Member
|
Fixes: #4156 |
himself65
reviewed
Aug 9, 2025
Member
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
Should we probably uninstall https-pem?
Member
|
I prefer generating them, as including the certs will generate additional work here. |
Contributor
Author
|
lets get the ci green again |
Member
Node.js has https://github.com/nodejs/node/tree/main/test/fixtures/keys which are generated by https://github.com/nodejs/node/blob/main/test/fixtures/keys/Makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeJs v24.5.0 uses OpenSSL 3.5.1. The ssl certificate of
https-pemis too weak and thus resulting in breaking our ci.I took the certs from the cpython project. They were generated by @encukou .
You can find the key and cert in the cpython repo.
https://github.com/python/cpython/blob/main/Lib/test/certdata/ssl_cert.pem
https://github.com/python/cpython/blob/main/Lib/test/certdata/ssl_key.pem
I looked into nodejs core repo to find some other keys which could work, but I am not that deep into the ssl certs topic, and well, this keys work?! And I think to get the CI fixed is more important.
@richardlau
is there a key in node core, that we could use?