From b11af3062532c865150c57e1bddf53d99a093b8d Mon Sep 17 00:00:00 2001 From: mritunjaygoutam12 Date: Sat, 3 Nov 2018 03:42:26 +0530 Subject: [PATCH 1/3] correct link to test coverage command --- doc/guides/writing-tests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index 2059a709ff8a95..bb765d52026dbe 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -423,5 +423,5 @@ To generate a test coverage report, see the [all maintained branches]: https://github.com/nodejs/lts [node.green]: http://node.green/ [test fixture]: https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#test-fixtures-using-the-same-data-configuration-for-multiple-tests -[Test Coverage section of the Pull Requests guide]: https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#test-coverage +[Test Coverage section of the Pull Requests guide]: https://github.com/nodejs/node/blob/master/BUILDING.md#running-coverage [directory structure overview]: https://github.com/nodejs/node/blob/master/test/README.md#test-directories From cbc5710dc23fd337aa808cb017e1eb362775e8c9 Mon Sep 17 00:00:00 2001 From: mohit singh Date: Sat, 3 Nov 2018 10:46:07 +0530 Subject: [PATCH 2/3] test coverage link description --- doc/guides/writing-tests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index bb765d52026dbe..f058a04bc53b6c 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -423,5 +423,5 @@ To generate a test coverage report, see the [all maintained branches]: https://github.com/nodejs/lts [node.green]: http://node.green/ [test fixture]: https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#test-fixtures-using-the-same-data-configuration-for-multiple-tests -[Test Coverage section of the Pull Requests guide]: https://github.com/nodejs/node/blob/master/BUILDING.md#running-coverage +[Test Coverage section of the Building guide]: https://github.com/nodejs/node/blob/master/BUILDING.md#running-coverage [directory structure overview]: https://github.com/nodejs/node/blob/master/test/README.md#test-directories From d71ddc974d92e6de03c689ab6d7aa900cb481c9a Mon Sep 17 00:00:00 2001 From: mohit singh Date: Sun, 4 Nov 2018 03:05:57 +0530 Subject: [PATCH 3/3] Update writing-tests.md --- doc/guides/writing-tests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index f058a04bc53b6c..4d0c0307bbd765 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -414,7 +414,7 @@ will depend on what is being tested if this is required or not. ### Test Coverage To generate a test coverage report, see the -[Test Coverage section of the Pull Requests guide][]. +[Test Coverage section of the Building guide][]. [ASCII]: http://man7.org/linux/man-pages/man7/ascii.7.html [Google Test]: https://github.com/google/googletest