tty: make process.binding('tty_wrap') internal #22477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
33 tasks
jasnell
added
the
semver-major
jasnell
approved these changes
Aug 23, 2018
BridgeAR
approved these changes
Aug 23, 2018
Contributor
Author
|
This needs to be rebased and a CI run, but first it needs another review from @nodejs/tsc. |
targos
approved these changes
Aug 27, 2018
PR-URL: nodejs#22477 Refs: nodejs#22160 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Contributor
Author
|
Green (well, yellow) CI: https://ci.nodejs.org/job/node-test-pull-request/16852/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #22160
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes