compiler options for building OpenSSL dependency on Windows

* **Version**: master
* **Platform**: Windows
* **Subsystem**: build, deps



As per https://github.com/nodejs/node/pull/31311#discussion_r365502964 it looks like gyp ignores `cflags` on Windows when generating for Visual Studio (msvs) so the following from our gyp files for OpenSSL are currently ignored: https://github.com/nodejs/node/blob/be46a7257b36ce5519d56e50db12f91b82d194f4/deps/openssl/openssl_common.gypi#L32-L34

These settings appear to mirror those in OpenSSL's own build configuration:
https://github.com/nodejs/node/blob/be055d103c85d4b716f3013f8c63b39c7dc0425b/deps/openssl/openssl/Configurations/10-main.conf#L1219
https://github.com/nodejs/node/blob/be055d103c85d4b716f3013f8c63b39c7dc0425b/deps/openssl/openssl/Configurations/10-main.conf#L1242-L1252

In practice we appear to be getting most of these via settings in our `common.gypi`. For the ones we aren't explicitly setting I don't know enough about Windows for the `-Gs0` case to know if this is an issue we want to address (cc @nodejs/platform-windows).

# Options we already set
## [`-W3`](https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=vs-2019)
from https://github.com/nodejs/node/blob/f4797ff1ef7304659d747d181ec1e7afac408d50/common.gypi#L229 (refs: [VCCLCompilerTool.WarningLevel Property](https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.vcclcompilertool.warninglevel?view=visualstudiosdk-2017&viewFallbackFrom=visualstudiosdk-2019))

## [`-GF`](https://docs.microsoft.com/en-us/cpp/build/reference/gf-eliminate-duplicate-strings?view=vs-2019)
from https://github.com/nodejs/node/blob/fe058188a158cea61656b6ecb4517abf4a679353/common.gypi#L226 (refs: [VCCLCompilerTool.StringPooling Property](https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.vcclcompilertool.stringpooling?view=visualstudiosdk-2017))

## [`-Gy`](https://docs.microsoft.com/en-us/cpp/build/reference/gy-enable-function-level-linking?view=vs-2019)
from https://github.com/nodejs/node/blob/be46a7257b36ce5519d56e50db12f91b82d194f4/common.gypi#L196 (refs: [VCCLCompilerTool.EnableFunctionLevelLinking Property](https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.vcclcompilertool.enablefunctionlevellinking?view=visualstudiosdk-2017))

## [`-nologo`](https://docs.microsoft.com/en-us/cpp/build/reference/nologo-suppress-startup-banner-c-cpp?view=vs-2019)
from https://github.com/nodejs/node/blob/fe058188a158cea61656b6ecb4517abf4a679353/common.gypi#L227 (refs: [VCCLCompilerTool.SuppressStartupBanner Property](https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.vcclcompilertool.suppressstartupbanner?view=visualstudiosdk-2017))


# Options we don't currently explicitly set

## [`-wd4090`](https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=vs-2019) 
being addressed by https://github.com/nodejs/node/pull/31311

## [`-Gs0`](https://docs.microsoft.com/en-us/cpp/build/reference/gs-control-stack-checking-calls?view=vs-2019)
I don't know if there's a good reason that OpenSSL sets this. The MSDN docs says 
> **/Gs0** initiates stack probes for every function call that requires storage for local variables. This can have a negative impact on performance.


## [`/O2`](https://docs.microsoft.com/en-us/cpp/build/reference/o1-o2-minimize-size-maximize-speed?view=vs-2019)
We currently set https://github.com/nodejs/node/blob/fe058188a158cea61656b6ecb4517abf4a679353/common.gypi#L201 (refs: [VCCLCompilerTool.Optimization Property](https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.vcclcompilertool.optimization?view=visualstudiosdk-2017)) which [maps 3 to /Ox](https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.optimizeoption?view=visualstudiosdk-2017) and [`/Ox`](https://docs.microsoft.com/en-us/cpp/build/reference/ox-full-optimization?view=vs-2019):
> The **/Ox** compiler option enables the **/O** compiler options that favor speed. The **/Ox** compiler option does not include the additional [/GF (Eliminate Duplicate Strings)](https://docs.microsoft.com/en-us/cpp/build/reference/gf-eliminate-duplicate-strings?view=vs-2019) and [/Gy (Enable Function-Level Linking)](https://docs.microsoft.com/en-us/cpp/build/reference/gy-enable-function-level-linking?view=vs-2019) options enabled by [/O1 or /O2 (Minimize Size, Maximize Speed)](https://docs.microsoft.com/en-us/cpp/build/reference/o1-o2-minimize-size-maximize-speed?view=vs-2019). 

but we switch on `/GF` and `/Gy` via `StringPooling` and `EnableFunctionLevelLinking` above so this works out?

	CFLAGS => add(picker(debug => '/Od',
	release => '/O2')),
	cflags => add(picker(default => '/Gs0 /GF /Gy',
	debug =>
	sub {
	($disabled{shared} ? "" : "/MDd");
	},
	release =>
	sub {
	($disabled{shared} ? "" : "/MD");
	})),

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

compiler options for building OpenSSL dependency on Windows #31330

Options we already set

`-W3`

`-GF`

`-Gy`

`-nologo`

Options we don't currently explicitly set

`-wd4090`

`-Gs0`

`/O2`

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	'cflags': [
	'-W3', '-wd4090', '-Gs0', '-GF', '-Gy', '-nologo','/O2',
	],

Uh oh!

compiler options for building OpenSSL dependency on Windows #31330

Description

Options we already set

-W3

-GF

-Gy

-nologo

Options we don't currently explicitly set

-wd4090

-Gs0

/O2

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`-W3`

`-GF`

`-Gy`

`-nologo`

`-wd4090`

`-Gs0`

`/O2`