url: move process.binding('url') to internalBinding

PR-URL: #22204
Refs: #22160
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>

Author: starkwang

lib/internal/bootstrap/node.js

@@ -375,7 +375,8 @@
         'tcp_wrap',
         'tls_wrap',
         'util',
-        'async_wrap']);
+        'async_wrap',
+        'url']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?
         internalBinding(name) :

lib/internal/url.js

@@ -37,6 +37,7 @@ let querystring;
 const { platform } = process;
 const isWindows = platform === 'win32';
 
+const { internalBinding } = require('internal/bootstrap/loaders');
 const {
   domainToASCII: _domainToASCII,
   domainToUnicode: _domainToUnicode,
@@ -60,7 +61,7 @@ const {
   kPort,
   kQuery,
   kSchemeStart
-} = process.binding('url');
+} = internalBinding('url');
 
 const context = Symbol('context');
 const cannotBeBase = Symbol('cannot-be-base');

src/node_url.cc

@@ -2420,4 +2420,4 @@ static void Initialize(Local<Object> target,
 }  // namespace url
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(url, node::url::Initialize)

test/parallel/test-process-binding-internalbinding-whitelist.js

@@ -12,3 +12,4 @@ assert(process.binding('v8'));
 assert(process.binding('stream_wrap'));
 assert(process.binding('signal_wrap'));
 assert(process.binding('contextify'));
+assert(process.binding('url'));