src: replace impossible THROW with CHECK

The JS layer already verifies that divisor_bits is either a non-negative
32-bit signed integer or null/undefined, in which case it passes -1 to
the C++ layer. In either case, the C++ layer receives a 32-bit signed
integer greater than or equal to -1.

Author: tniessen

src/crypto/crypto_dsa.cc

@@ -89,10 +89,7 @@ Maybe<bool> DsaKeyGenTraits::AdditionalConfig(
 
   params->params.modulus_bits = args[*offset].As<Uint32>()->Value();
   params->params.divisor_bits = args[*offset + 1].As<Int32>()->Value();
-  if (params->params.divisor_bits < -1) {
-    THROW_ERR_OUT_OF_RANGE(env, "invalid value for divisor_bits");
-    return Nothing<bool>();
-  }
+  CHECK_GE(params->params.divisor_bits, -1);
 
   *offset += 2;
 

test/parallel/test-crypto-keygen.js

@@ -1278,7 +1278,7 @@ const sec1EncExp = (cipher) => getRegExpForPEM('EC PRIVATE KEY', cipher);
   }
 
   // Test invalid divisor lengths. (out of range)
-  for (const divisorLength of [-6, -9, 2147483648]) {
+  for (const divisorLength of [-1, -6, -9, 2147483648]) {
     assert.throws(() => generateKeyPair('dsa', {
       modulusLength: 2048,
       divisorLength