buffer: changing let in for loops back to var

Using let in for loops showed a regression in 4.4.0. @ofrobots
suggested that we avoid using let in for loops until TurboFan becomes
the default optimiser.

The regression that was detected was when looking at how long it took
to create a new buffer from an array of data.

When using `for (let i=0; i<length; i++) ` we saw the operation take
almost 40% longer compared to `var i=0`.

PR-URL: #5819
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Ref: http://github.com/nodejs/benchmarking/issues/38

Author: gareth-ellis

lib/buffer.js

@@ -165,7 +165,7 @@ function fromString(string, encoding) {
 function fromArrayLike(obj) {
   const length = obj.length;
   const b = allocate(length);
-  for (let i = 0; i < length; i++)
+  for (var i = 0; i < length; i++)
     b[i] = obj[i] & 255;
   return b;
 }
@@ -256,6 +256,7 @@ Buffer.isEncoding = function(encoding) {
 
 
 Buffer.concat = function(list, length) {
+  var i;
   if (!Array.isArray(list))
     throw new TypeError('list argument must be an Array of Buffers');
 
@@ -264,15 +265,15 @@ Buffer.concat = function(list, length) {
 
   if (length === undefined) {
     length = 0;
-    for (let i = 0; i < list.length; i++)
+    for (i = 0; i < list.length; i++)
       length += list[i].length;
   } else {
     length = length >>> 0;
   }
 
   var buffer = Buffer.allocUnsafe(length);
   var pos = 0;
-  for (let i = 0; i < list.length; i++) {
+  for (i = 0; i < list.length; i++) {
     var buf = list[i];
     if (!Buffer.isBuffer(buf))
       throw new TypeError('list argument must be an Array of Buffers');