util: fix deprecated class prototype

Ensure the wrapped class prototype is exactly the unwrapped class
prototype, rather than an object whose prototype is the unwrapped
class prototype.

This ensures that instances of the unwrapped class are instances
of the wrapped class. This is useful when both a wrapped class and
a factory for the unwrapped class are both exposed.

Ref: #8103
PR-URL: #8105
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: bengl

lib/internal/util.js

@@ -66,7 +66,10 @@ exports._deprecate = function(fn, msg) {
   // The wrapper will keep the same prototype as fn to maintain prototype chain
   Object.setPrototypeOf(deprecated, fn);
   if (fn.prototype) {
-    Object.setPrototypeOf(deprecated.prototype, fn.prototype);
+    // Setting this (rather than using Object.setPrototype, as above) ensures
+    // that calling the unwrapped constructor gives an instanceof the wrapped
+    // constructor.
+    deprecated.prototype = fn.prototype;
   }
 
   return deprecated;

test/fixtures/deprecated-userland-class.js

@@ -7,6 +7,9 @@ class deprecatedClass {
 const deprecated = util.deprecate(deprecatedClass, 'deprecatedClass is deprecated.');
 
 const instance = new deprecated();
+const deprecatedInstance = new deprecatedClass();
 
 assert(instance instanceof deprecated);
 assert(instance instanceof deprecatedClass);
+assert(deprecatedInstance instanceof deprecated);
+assert(deprecatedInstance instanceof deprecatedClass);