docs: Update windows installation instructions in README.md #2882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raress96
changed the title
StefanStojanovic
requested changes
Jul 11, 2023
Contributor
StefanStojanovic
left a comment
StefanStojanovic
left a comment
There was a problem hiding this comment.
The change in the workloads section happened between VS2017 and VS2019. Here is a screenshot from VS2017 build tools installer:
and here are from VS2019 and VS2022:
With all of that in mind, I think both workload names should be in the README.md file and potentially another sentence telling in which versions of build tools which workload is expected.
Contributor
|
@raress96 I forgot to thank you for your effort in the previous comment. Also wanted to tell you that if you do not have time to make the change I requested, you can let me know and I'll do it. |
Contributor
Author
|
Readme updated again, hopefully it is more clearer now for new users. |
StefanStojanovic
approved these changes
Jul 13, 2023
Contributor
StefanStojanovic
left a comment
StefanStojanovic
left a comment
There was a problem hiding this comment.
That's much clearer, thanks @raress96!
lukekarrys
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Update windows installation instructions in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Update readme for windows installation. Fixes #2637