This repository was archived by the owner on Oct 15, 2020. It is now read-only.
Update node-chakracore with nodejs/master changes #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment stating it was deprecated was added in 2011 via 4ef8f06. It is time to actually deprecate it. PR-URL: nodejs/node#5049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Add fromArrayLike() to handle logic of copying in values from array-like argument. PR-URL: nodejs/node#4948 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
`fs.read` supports a deprecated string interface version, which is not documented. It was intended to be deprecated in this commit in 2010 nodejs/node@c93e0aa This patch issues a deprecation message saying the usage of this interface is deprecated. PR-URL: nodejs/node#4525 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
There was a very subtle change in behavior introduced with 27def4f In the past if querystring.parse was given Infinity for maxKeys, everything worked as expected. Check to see is maxKeys is Infinity before forwarding the value to String.prototype.split which causes this regression PR-URL: nodejs/node#5066 Reviewed-By: Evan Lucas <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Currently a debug context is created for various calls to util. If the node debugger is being run the main context is the debug context. In this case node_contextify was freeing the debug context and causing everything to explode. This change moves around the logic and no longer frees the context. There is a concern about the dangling pointer The regression test was adapted from code submitted by @3y3 in #4815 Fixes: nodejs/node#4440 Fixes: nodejs/node#4815 Fixes: nodejs/node#4597 Fixes: nodejs/node#4952 PR-URL: nodejs/node#4815 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]>
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: nodejs/node#5082 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Ref: nodejs/node#4830 Ref: nodejs/node#3635 Ref: nodejs/node#4526
Remove stray square brackets from dgram documentation. PR-URL: nodejs/node#5114 Reviewed-By: Brian White <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]>
Prefer using Object.setPrototypeOf() instead. PR-URL: nodejs/node#5069 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
* Explit throw on deprecated Buffer.write(...) * Update tests, remove obsolete Buffer.write(...) * Add comment for obsolete Buffer.write(...) PR-URL: nodejs/node#5048 Reviewed-By: Brian White <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: nodejs/node#4526 PR-URL: nodejs/node#5125 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: nodejs/node#5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Mea culpa, looks like I forgot to update console.markdown in commit dac1d38 ("doc: stdout/stderr can block when directed to file"). This commit rectifies that. Refs: nodejs/node#5131 PR-URL: nodejs/node#5133 Reviewed-By: Brian White <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Fixes: #5124 See: nodejs/node#4374 PR-URL: nodejs/node#5130 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
test whether the various resolve functions cause ENOTFOUND when trying to resolve a known invalid domain/hostname. PR-URL: nodejs/node#4921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Brian White <[email protected]>
Resolving plain PTR records is used beyond reverse DNS, most prominently with DNS-SD (RFC6763). This adds dns.resolvePtr(), and uses it (instead of dns.reverse()) in dns.resolve(). PR-URL: nodejs/node#4921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Brian White <[email protected]>
Clarifies the code of conduct by making the following changes: - Adds section headings to make it easier to quickly parse. - Adds easy to find contact information. - Adds link to TSC moderation policies. - Moves attribution to the bottom of the page. PR-URL: nodejs/node#5107 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Kat Marchán <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
According to documentation all certificates specified in `pfx` option should be treated as a CA certificates too. While it doesn't seem to be logically correct to me, we can't afford to break API stability at this point. Fix: #5100 PR-URL: nodejs/node#5109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
`sk_X509_pop_free` should be used instead of `sk_X509_free` to free all items in queue too, not just the queue itself. PR-URL: nodejs/node#5109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
PR-URL: nodejs/node#5090 Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes `LoadLibraryW`. When an ASCII string is passed to that function it crashes. PR-URL: nodejs/node#226 Reviewed-By: Bert Belder <[email protected]>
PR-URL: nodejs/node#5090 Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: nodejs/node#5118 Reviewed-By: Roman Reiss <[email protected]>
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: nodejs/node#5144 Reviewed-By: Rich Trott <[email protected]>
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: nodejs/node#5144 Fix: nodejs/node#5109 PR-URL: nodejs/node#5150 Reviewed-By: Rich Trott <[email protected]>
Improves the performance when moving small buffers by 5%, and it adds a benchmark to avoid regression in that area. In all other cases it is equally performant to current master. Full performance results available at: https://gist.github.com/mcollina/717c35ad07d15710b6b9. PR-URL: nodejs/node#4354 Reviewed-By: James M Snell <[email protected]>
Prevent deoptimization of process.nextTick by removing the try finally block. This is not necessary as the next tick queue will be reset anyway, no matter if the callback throws or not. Use a predefined array size prevents resizing the array and is therefor faster. PR-URL: nodejs/node#5092 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Changes the parsing of parameter types in the doc html gen Links to either MDN or nodejs docs depending on type See #4350 PR-URL: nodejs/node#4741 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes several type references in the docs so that the doc html gen tool that parses them can put the correct links in. Changes css styling for the generated type links. PR-URL: nodejs/node#4741 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
PR-URL: nodejs/node#5081 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
PR-URL: nodejs/node#5117 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve nodejs/node#5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65 PR-URL: nodejs/node#5293 Fixes: nodejs/node#5089 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
The deopt issues arose from the use of const in specific situations that v8 does not fully support yet. Fixes: nodejs/node#5299 PR-URL: nodejs/node#5300 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]>
ESLint 2.1.0 is coming. Some lint rules have been tightened. PR-URL: nodejs/node#5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>
We are about to upgrade from ESlint 1 to ESLint 2. Remove lint rules that will not exist in ESLint 2. PR-URL: nodejs/node#5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: nodejs/node#5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Now that we are using ESLint 2, replace ESLint 1 rules with their ESLint 2 equivalents. PR-URL: nodejs/node#5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>
By doing this users can use a Map object for storing information instead of modifying the handle object. PR-URL: nodejs/node#4600 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
All other hooks have uid as the first argument, this makes it consistent for all hooks. PR-URL: nodejs/node#4600 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
When the parent uid is required it is not necessary to store the uid in the parent handle object. PR-URL: nodejs/node#4600 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Ref: nodejs/node#5302 PR-URL: nodejs/node#5303 Reviewed-By: Rich Trott <[email protected]>
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: nodejs/node#5268 Fixes: nodejs/node#4343 PR-URL: nodejs/node#5269 Reviewed-By: James M Snell <[email protected]>
Remove the limit of requests to be sent (128) as in some conditions it was reached without the `error` event being fired, causing the test to fail. Remove the initial timeout. Remove some variables used to check the validity of the test and replace them with `common.mustCall` and `common.fail` calls. PR-URL: nodejs/node#4970 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs/node#5106 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is guaranteed to be truthy due to line 521. PR-URL: nodejs/node#5319 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: nodejs/node#5269 PR-URL: nodejs/node#5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
The changes to the file argument of execFile in #4504 make it appear that execFile requires an absolute or relative path to the executable file, when it also supports a filename which will be resolved using $PATH. Although the example makes this clear, assuming there isn't a node binary in $CWD, it's easy to overlook. This commit clarifies that point. It also updates the argument description for execFileSync to match, since it was overlooked in #4504 and behaves identically. PR-URL: nodejs/node#5310 Reviewed-By: James M Snell <[email protected]>
Method `LinkedBinding` must return the same "exports" property of the module as cached, because property can be overridden by an initialization function. PR-URL: nodejs/node#5337 Reviewed-By: Ben Noordhuis <[email protected]>
Fix segmentation faults when compiling the same code with `produceCachedData` option. V8 ignores the option when the code is in its compilation cache and does not return cached data. Added `cachedDataProduced` property to `v8.Script` to denote whether the cached data is produced successfully. PR-URL: nodejs/node#5343 Reviewed-By: Fedor Indutny <[email protected]>
There are a few places where tests repeatedly concatenate strings to
themselves in order to make them very long. Using `.repeat()` makes the
code clearer.
For example, before:
for (var i = 0; i < 8; ++i) lots_of_headers += lots_of_headers;
After:
lots_of_headers = lots_of_headers.repeat(256);
Using `.repeat()` makes it clear that the string will be repeated 256
times rather than 8 times. ("What?! That first one doesn't repeat 256
times! It only repeats 8... Oh, wait. Yes, I see your point now.")
PR-URL: nodejs/node#5311
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires PR-URL: nodejs/node#5320 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs/node#5356 Reviewed-By: Myles Borins <[email protected]>
Member
Author
|
@nodejs/chakracore , @nodejs/node-chakracore - FYI. |
|
LGTM. @agarwal-sandeep please also take a look. |
Contributor
|
Looks good to me. |
Merge 2678e14 of nodejs/node `master` branch into nodejs/node-chakracore PR-URL: nodejs#30 Reviewed-By: Sandeep Agarwal <[email protected]> Reviewed-By: Jianchun Xu <[email protected]>
There was a feedback that with node + chakracore people rely on `--v8-options` switch and expect to get options text. Implemented it for chakrashim which just prints options available to node running with chakracore engine. PR-URL: nodejs#30 Reviewed-By: Sandeep Agarwal <[email protected]> Reviewed-By: Jianchun Xu <[email protected]> Fixes: nodejs#10
Skip running this test because node+chakracore doesn't support -prof option. PR-URL: nodejs#30 Reviewed-By: Sandeep Agarwal <[email protected]> Reviewed-By: Jianchun Xu <[email protected]>
Includes following bug fix in chakracore that was observed in 4e46931 changes to `node.js`. * Fix to enable `{get}` as valid object literal. See chakra-core/ChakraCore#320 See Microsoft/Chakracore [release/1.1](https://github.com/Microsoft/ChakraCore/commits/release/1.1) for more details. PR-URL: nodejs#30 Reviewed-By: Sandeep Agarwal <[email protected]> Reviewed-By: Jianchun Xu <[email protected]>
kunalspathak
force-pushed
the
chakracore-next
branch
from
785b5f6 to
fc3cf3e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
43 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates node-chakracore with 2678e14 of nodejs/node "master" branch. All the commits, except last 3 commits are from nodejs/node repo and are present to retain the history.
Summary of last 3 commits are as follows: