Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 83e078c

Browse files
committed
test: Disabled several unittest for node chakracore
* Disabled several debugger test because chakracore doesn't have support yet. * Skip `Buffer.toString()` test that verifies using v8 specific `kStringMaxLength` variable. * Because of error difference, added baselines for some test for chakra This gets us to 29 failures which are either not implemented or bugs in chakrashim. PR-URL: #25 Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jianchun Xu <[email protected]>
1 parent 47064b8 commit 83e078c

25 files changed

+199
-7
lines changed
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
[eval]
2+
SyntaxError: 'with' statements are not allowed in strict mode
3+
at exports.runInThisContext (vm.js:*)
4+
at Anonymous function ([eval]-wrapper:*:*)
5+
at Module.prototype._compile (module.js:*:*)
6+
at Anonymous function (node.js:*:*)
7+
at nextTickCallbackWith0Args (node.js:*:*)
8+
at _tickCallback (node.js:*:*)
9+
42
10+
42
11+
Error: hello
12+
at Global code ([eval]:1:1)
13+
at exports.runInThisContext (vm.js:*)
14+
at Anonymous function ([eval]-wrapper:*:*)
15+
at Module.prototype._compile (module.js:*:*)
16+
at Anonymous function (node.js:*:*)
17+
at nextTickCallbackWith0Args (node.js:*:*)
18+
at _tickCallback (node.js:*:*)
19+
Error: hello
20+
at Global code ([eval]:1:15)
21+
at exports.runInThisContext (vm.js:*)
22+
at Anonymous function ([eval]-wrapper:*:*)
23+
at Module.prototype._compile (module.js:*:*)
24+
at Anonymous function (node.js:*:*)
25+
at nextTickCallbackWith0Args (node.js:*:*)
26+
at _tickCallback (node.js:*:*)
27+
100
28+
ReferenceError: Variable undefined in strict mode
29+
at Global code ([eval]:1:28)
30+
at exports.runInThisContext (vm.js:*)
31+
at Anonymous function ([eval]-wrapper:*:*)
32+
at Module.prototype._compile (module.js:*:*)
33+
at Anonymous function (node.js:*:*)
34+
at nextTickCallbackWith0Args (node.js:*:*)
35+
at _tickCallback (node.js:*:*)
36+
10
37+
10
38+
done
File renamed without changes.
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
[stdin]
2+
SyntaxError: 'with' statements are not allowed in strict mode
3+
at exports.runInThisContext (vm.js:*)
4+
at Anonymous function ([stdin]-wrapper:*:*)
5+
at Module.prototype._compile (module.js:*:*)
6+
at Anonymous function (node.js:*:*)
7+
at nextTickCallbackWith0Args (node.js:*:*)
8+
at _tickCallback (node.js:*:*)
9+
42
10+
42
11+
Error: hello
12+
at Global code ([stdin]:*)
13+
at exports.runInThisContext (vm.js:*)
14+
at Anonymous function ([stdin]-wrapper:*:*)
15+
at Module.prototype._compile (module.js:*:*)
16+
at Anonymous function (node.js:*:*)
17+
at nextTickCallbackWith0Args (node.js:*:*)
18+
at _tickCallback (node.js:*:*)
19+
Error: hello
20+
at Global code ([stdin]:*)
21+
at exports.runInThisContext (vm.js:*)
22+
at Anonymous function ([stdin]-wrapper:*:*)
23+
at Module.prototype._compile (module.js:*:*)
24+
at Anonymous function (node.js:*:*)
25+
at nextTickCallbackWith0Args (node.js:*:*)
26+
at _tickCallback (node.js:*:*)
27+
100
28+
ReferenceError: Variable undefined in strict mode
29+
at Global code ([stdin]:*)
30+
at exports.runInThisContext (vm.js:*)
31+
at Anonymous function ([stdin]-wrapper:*:*)
32+
at Module.prototype._compile (module.js:*:*)
33+
at Anonymous function (node.js:*:*)
34+
at nextTickCallbackWith0Args (node.js:*:*)
35+
at _tickCallback (node.js:*:*)
36+
10
37+
10
38+
done
File renamed without changes.

test/message/vm_display_syntax_error.chakracore.out

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,13 @@ SyntaxError: Expected identifier
99
at Module.runMain (module.js:*)
1010
at startup (node.js:*)
1111
at Anonymous function (node.js:*)
12+
SyntaxError: Expected identifier
13+
at exports.runInThisContext (vm.js:*)
14+
at Anonymous function (*test*message*vm_display_syntax_error.js:*)
15+
at Module.prototype._compile (module.js:*)
16+
at Module._extensions[.js] (module.js:*)
17+
at Module.prototype.load (module.js:*)
18+
at Module._load (module.js:*)
19+
at Module.runMain (module.js:*)
20+
at startup (node.js:*)
21+
at Anonymous function (node.js:*)

test/parallel/test-cli-syntax.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ var syntaxArgs = [
5555

5656
// stderr should have a syntax error message
5757
var match = c.stderr.match(common.engineSpecificMessage({
58-
v8: /^SyntaxError: Unexpected identifier$/m,
59-
chakracore: /^SyntaxError: Expected ';'$/m})
60-
);
58+
v8: /^SyntaxError: Unexpected identifier$/m,
59+
chakracore: /^SyntaxError: Expected ';'$/m})
60+
);
6161
assert(match, 'stderr incorrect');
6262

6363
assert.equal(c.status, 1, 'code == ' + c.status);

test/parallel/test-debug-brk.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ const common = require('../common');
44
const assert = require('assert');
55
const spawnSync = require('child_process').spawnSync;
66

7+
if (common.isChakraEngine) {
8+
console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
9+
'because debugger support is not implemented yet.');
10+
return;
11+
}
12+
713
const args = [`--debug-brk=${common.PORT}`, `-e`, `0`];
814
const proc = spawnSync(process.execPath, args, {encoding: 'utf8'});
915
assert(/Debugger listening on/.test(proc.stderr));

test/parallel/test-debug-no-context.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ const common = require('../common');
44
const assert = require('assert');
55
const spawn = require('child_process').spawn;
66

7+
if (common.isChakraEngine) {
8+
console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
9+
'because debugger support is not implemented yet.');
10+
return;
11+
}
12+
713
const args = [`--debug`, `--debug-port=${common.PORT}`, `--interactive`];
814
const proc = spawn(process.execPath, args, { stdio: 'pipe' });
915
proc.stdin.write(`

test/parallel/test-debug-port-cluster.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ var common = require('../common');
33
var assert = require('assert');
44
var spawn = require('child_process').spawn;
55

6+
if (common.isChakraEngine) {
7+
console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
8+
'because debugger support is not implemented yet.');
9+
return;
10+
}
11+
612
const PORT_MIN = common.PORT + 1337;
713
const PORT_MAX = PORT_MIN + 2;
814

test/parallel/test-debug-port-from-cmdline.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ var common = require('../common');
33
var assert = require('assert');
44
var spawn = require('child_process').spawn;
55

6+
if (common.isChakraEngine) {
7+
console.log('1..0 # Skipped: This test is disabled for chakra engine ' +
8+
'because debugger support is not implemented yet.');
9+
return;
10+
}
11+
612
var debugPort = common.PORT;
713
var args = ['--interactive', '--debug-port=' + debugPort];
814
var childOptions = { stdio: ['pipe', 'pipe', 'pipe', 'ipc'] };

0 commit comments

Comments
 (0)