Skip to content

Fix session metrics for stream upstreams #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Fix session metrics for stream upstreams #25

merged 1 commit into from
Jul 16, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • 4xx and 5xx session metrics are not correctly unmarshalled. Instead
    they are ignored. This is due to a typo.

Bug introduced in: c9fb4ac

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley
Fix session metrics for stream upstreams
879715d 
* 4xx and 5xx session metrics are not correctly unmarshalled. Instead
they are ignored.

Bug introduced in: c9fb4ac
@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Jul 15, 2019
@Dean-Coakley Dean-Coakley requested review from pleshakov and Rulox July 15, 2019 16:05
@Dean-Coakley Dean-Coakley self-assigned this Jul 15, 2019
pleshakov
pleshakov approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit f8b65d2 into master Jul 16, 2019
@Dean-Coakley Dean-Coakley deleted the fix/stream-session-metrics branch July 16, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox