Skip to content

Commit 60d73be

Browse files
authored
add change for scc and default-server-secret (#98)
* add change for scc and default-server-secret * update examples
1 parent e7d30ba commit 60d73be

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ Note: The NGINX Ingress Operator works only for NGINX Ingress Controller version
3535

3636
1. Install the NGINX Ingress Operator. See [docs](./docs/installation.md).
3737
<br> NOTE: To use TransportServers as part of your NGINX Ingress Controller configuration, a GlobalConfiguration resource must be created *before* starting the Operator - [see the notes](./examples/deployment-oss-min/README.md#TransportServers)
38-
2. Create a default server secret on the cluster - an example yaml for this can be found in the [examples folder](https://github.com/nginxinc/nginx-ingress-helm-operator/blob/v1.4.0/examples/default-server-secret.yaml)
38+
2. Creating the default-server-secret.yaml is optional and it is recommended that users provide their own certificate. An example yaml for this can be found in the [examples folder](https://github.com/nginxinc/nginx-ingress-helm-operator/blob/main/examples/default-server-secret.yaml)
3939
3. (If using OpenShift) Create the scc resource on the cluster by applying the scc.yaml file found in the `resources` folder of this repo:
4040
```shell
41-
kubectl apply -f https://raw.githubusercontent.com/nginxinc/nginx-ingress-helm-operator/v1.4.0/resources/scc.yaml
41+
kubectl apply -f https://raw.githubusercontent.com/nginxinc/nginx-ingress-helm-operator/main/resources/scc.yaml
4242
```
4343
4. Deploy a new NGINX Ingress Controller using the [NginxIngress](./config/samples/charts_v1alpha1_nginxingress.yaml) Custom Resource:
4444
* Use the name of the default server secret created above for `controller.defaultTLS.secret` field (needs to be in the form `namespace/name`)

examples/deployment-oss-min/nginx-ingress-controller.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ spec:
66
# Default values copied from <project_dir>/helm-charts/nginx-ingress/values.yaml
77
controller:
88
defaultTLS:
9-
secret: nginx-ingress/default-server-secret
9+
secret: ""
1010
enableCustomResources: true
1111
image:
1212
pullPolicy: IfNotPresent

examples/deployment-plus-min/nginx-ingress-controller.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ spec:
66
# Default values copied from <project_dir>/helm-charts/nginx-ingress/values.yaml
77
controller:
88
defaultTLS:
9-
secret: nginx-ingress/default-server-secret
9+
secret: ""
1010
enableCustomResources: true
1111
image:
1212
pullPolicy: IfNotPresent

0 commit comments

Comments
 (0)