chore: Use Value.Elem instead of reflect.Indirect for readability

rhansen · rhansen · commit ea1817d0a723 · 2023-01-23T20:39:41.000-05:00
diff --git a/internal/template/template.go b/internal/template/template.go
@@ -29,7 +29,7 @@ func getArrayValues(funcName string, entries interface{}) (*reflect.Value, error
 	kind := entriesVal.Kind()
 
 	if kind == reflect.Ptr {
-		entriesVal = reflect.Indirect(entriesVal)
+		entriesVal = entriesVal.Elem()
 		kind = entriesVal.Kind()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func getArrayValues(funcName string, entries interface{}) (*reflect.Value, error`
`29`	`29`	`kind := entriesVal.Kind()`
`30`	`30`
`31`	`31`	`if kind == reflect.Ptr {`
`32`		`- entriesVal = reflect.Indirect(entriesVal)`
	`32`	`+ entriesVal = entriesVal.Elem()`
`33`	`33`	`kind = entriesVal.Kind()`
`34`	`34`	`}`
`35`	`35`