Skip to content

Conversation

@jmalins
Copy link
Contributor

@jmalins jmalins commented May 12, 2016

jmalins and others added 2 commits May 11, 2016 17:12
screamy GLOBAL is deprecated on node V6
@nfarina
Copy link
Owner

nfarina commented May 12, 2016

Thanks for the PR! Will this break in previous Node versions? Or has the global lowercase var always been available?

@jmalins
Copy link
Contributor Author

jmalins commented May 12, 2016

I just checked the docs for some older versions of node... the farthest back I went was 0.4.0, and it was there. Travis shows it passing on 0.10, FWIW. I can't vouch that 'global' has always been there, but it's seems like it's been there for a while.

@jmalins
Copy link
Contributor Author

jmalins commented May 12, 2016

Actually, the node PR with the fix is informative... "This should be pretty low risk to remove", they say.
nodejs/node#1838

@nfarina
Copy link
Owner

nfarina commented May 12, 2016

Awesome - I also should have paid attention to the CI checks right on this page where Travis tested it against old versions of Node already ;)

Thanks again for the PR.

@nfarina nfarina merged commit c2f4d1e into nfarina:master May 12, 2016
@jmalins
Copy link
Contributor Author

jmalins commented May 12, 2016

Not a problem. Thanks for producing this lib... it's exactly what we needed and has worked great for us.

@nfarina
Copy link
Owner

nfarina commented May 12, 2016

So very glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants