Skip to content

fix(NcColorPicker): close popover on submit event #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(NcColorPicker): close popover on submit event #6336

merged 1 commit into from
Jan 14, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 27, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
2024-12-27_13h10_28 2024-12-27_13h09_37

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: colorpicker Related to the colorpicker component labels Dec 27, 2024
@Antreesy Antreesy added this to the 8.21.1 milestone Dec 27, 2024
@Antreesy Antreesy self-assigned this Dec 27, 2024
@skjnldsv skjnldsv enabled auto-merge December 28, 2024 17:08
@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 28, 2024

/backport to next

@skjnldsv skjnldsv merged commit d29d6d3 into master Jan 14, 2025
19 checks passed
@skjnldsv skjnldsv deleted the fix/noid/color-picker-submit branch January 14, 2025 08:02
@backportbot backportbot bot mentioned this pull request Jan 14, 2025
Merged
2 tasks
@juliusknorr juliusknorr mentioned this pull request Jan 14, 2025
Open
@susnux susnux modified the milestones: 8.21.1, 8.23.0 Jan 15, 2025
@Antreesy Antreesy mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews bug Something isn't working feature: colorpicker Related to the colorpicker component

Projects

None yet

Milestone

8.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @susnux @skjnldsv