From 6c2f5d16a018f5965eb3c80e7029c26c70c47ebe Mon Sep 17 00:00:00 2001 From: Philippe Serhal Date: Fri, 28 Feb 2025 06:47:35 -0500 Subject: [PATCH 1/2] ci: fix new job config Whoops. If your workflow is invalid, it doesn't even report as failed. And I hadn't marked the new jobs as required yet. --- .github/workflows/format.yml | 1 + .github/workflows/lint.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml index 4196baf083f..d834fc7eca1 100644 --- a/.github/workflows/format.yml +++ b/.github/workflows/format.yml @@ -10,6 +10,7 @@ jobs: format: name: Format if: "${{ !startsWith(github.head_ref, 'release-') }}" + runs-on: ubuntu-latest steps: - name: Git checkout uses: actions/checkout@v4 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 2260dc9f12b..272891b47f2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -10,6 +10,7 @@ jobs: lint: name: Lint if: "${{ !startsWith(github.head_ref, 'release-') }}" + runs-on: ubuntu-latest steps: - name: Git checkout uses: actions/checkout@v4 From 90ce9f5d90f2aa422cb0c2403dc40b14283a8636 Mon Sep 17 00:00:00 2001 From: Philippe Serhal Date: Fri, 28 Feb 2025 06:54:23 -0500 Subject: [PATCH 2/2] ci(lint): add missing build step to lint job --- .github/workflows/lint.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 272891b47f2..18333ee5edd 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -21,5 +21,8 @@ jobs: cache: npm - name: Install core dependencies run: npm ci --no-audit + # Almost not needed, but a single file in `scripts/` imports built code + - name: Build package + run: npm run build - name: Run lint run: npm run lint