Skip to content

Conversation

VitaliyR
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

For dev servers context, whenever the env var NETLIFY_DEV_SERVER_CHECK_SSG_ENDPOINTS is used (currently by dev server), skip the checks for the endpoint existence in case hidden-proxy header present.

Redirect works, but because of the endpoint check - it makes unnecessary request for the current server, which produces in case of remix unnecessary console output. For instance, when used with plugin-dev-server, which has redirect:

{
        from: `/.ntlfy-dev/*`,
        to: `http://localhost:${port}/:splat`,
        status: 200,
        headers: {
          'x-nf-hidden-proxy': 'true',
        },
}

Has next output when something tries to fire a request to /.ntlfy-dev/health

image

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@VitaliyR VitaliyR requested a review from davbree February 26, 2025 16:40
@VitaliyR VitaliyR requested a review from a team as a code owner February 26, 2025 16:40
Copy link

github-actions bot commented Feb 26, 2025

📊 Benchmark results

Comparing with 150fcc3

  • Dependency count: 1,197 (no change)
  • Package size: 298 MB ⬇️ 0.00% decrease vs. 150fcc3
  • Number of ts-expect-error directives: 729 (no change)

@VitaliyR VitaliyR merged commit 5fc044d into main Feb 27, 2025
49 checks passed
@VitaliyR VitaliyR deleted the vitaliir/WRFL-2261 branch February 27, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants