chore: improve on getPackageJson tests (#5582)

Author: danez

tests/unit/utils/get-package-json.test.mjs

@@ -2,8 +2,6 @@ import { readFile } from 'fs/promises'
 
 import { beforeEach, describe, expect, test, vi } from 'vitest'
 
-import getPackageJson from '../../../src/utils/get-package-json.mjs'
-
 vi.mock('fs/promises', async (importActual) => {
   const fs = await importActual()
 
@@ -14,20 +12,28 @@ vi.mock('fs/promises', async (importActual) => {
 })
 
 describe('getPackageJson', () => {
-  beforeEach(() => {
+  let getPackageJson
+  beforeEach(async () => {
     vi.clearAllMocks()
+    vi.resetModules()
+    const newImport = await import('../../../src/utils/get-package-json.mjs')
+    getPackageJson = newImport.default
   })
 
   test('should return the package.json of netlify-cli', async () => {
     const packageJson = await getPackageJson()
 
     expect(packageJson).not.toBeUndefined()
     expect(packageJson.name).toBe('netlify-cli')
+  })
 
+  test('should not re-read package.json', async () => {
+    // first call reads from file-system
+    await getPackageJson()
     expect(readFile).toHaveBeenCalledOnce()
-  })
+    vi.mocked(readFile).mockClear()
 
-  test('should not reread package.json', async () => {
+    // second call should cache and not read from file-system
     const packageJson = await getPackageJson()
 
     expect(packageJson).not.toBeUndefined()